Summary: | [iOS Simulator] http/tests/preload/viewport/meta-viewport-link-headers.php is a flaky failure. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lewis <jlewis3> | ||||||||
Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, commit-queue, jbedard, ryanhaddad, webkit-bug-importer, yoav, youennf | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
See Also: |
https://bugs.webkit.org/show_bug.cgi?id=171720 https://bugs.webkit.org/show_bug.cgi?id=178029 |
||||||||||
Attachments: |
|
Description
Matt Lewis
2017-05-23 11:45:55 PDT
diff: --- /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/http/tests/preload/viewport/meta-viewport-link-headers-expected.txt +++ /Volumes/Data/slave/ios-simulator-10-release-tests-wk2/build/layout-test-results/http/tests/preload/viewport/meta-viewport-link-headers-actual.txt @@ -1,3 +1,3 @@ -PASS Makes sure that Link headers support the media attribute and respond to <meta content=viewport> +FAIL Makes sure that Link headers support the media attribute and respond to <meta content=viewport> assert_true: expected true got false I'll look into that. Is it also flaky on ios? We only run the tests on simulator, so if you are asking about device, then I don't have an answer. Marked test as flaky. https://trac.webkit.org/changeset/217612/webkit/ Yoav, we have recently gotten layout tests running on iOS devices internally. This test is behaving the same way on devices as it is in the simulator. Moved the test expectation in <https://trac.webkit.org/changeset/221142/webkit/> Apologies. This has fallen off my radar. I'll take a look Created attachment 319177 [details]
Patch
Hey Youenn :) Care to take a look at this new and improved test patch? Comment on attachment 319177 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=319177&action=review > LayoutTests/http/tests/preload/viewport/meta-viewport-link-headers.php:32 > + }, 200); 200 might not be large enough. One approach would be to check for controlLoaded/smallLoaded every 50 ms or so. If both are not true after 10 or 20 tries, test would fail. Once both are true, a last check that largeLoaded is false could be done. Created attachment 319851 [details]
Patch
(In reply to youenn fablet from comment #9) > Comment on attachment 319177 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=319177&action=review > > > LayoutTests/http/tests/preload/viewport/meta-viewport-link-headers.php:32 > > + }, 200); > > 200 might not be large enough. > One approach would be to check for controlLoaded/smallLoaded every 50 ms or > so. > If both are not true after 10 or 20 tries, test would fail. > Once both are true, a last check that largeLoaded is false could be done. Changed to iterate over 50 ms intervals. PTAL :) Created attachment 319853 [details]
Patch
Comment on attachment 319853 [details]
Patch
Thanks for reviewing! :)
Comment on attachment 319853 [details] Patch Clearing flags on attachment: 319853 Committed r221604: <http://trac.webkit.org/changeset/221604> All reviewed patches have been landed. Closing bug. |