Bug 172515

Summary:	Layout Test imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html is an Image Failure
Product:	WebKit	Reporter:	Matt Lewis <jlewis3>
Component:	New Bugs	Assignee:	Nobody <webkit-unassigned>
Status:	NEW ---
Severity:	Normal	CC:	ecobos, ryanhaddad
Priority:	P2
Version:	WebKit Nightly Build
Hardware:	Unspecified
OS:	Unspecified
See Also:	https://bugs.webkit.org/show_bug.cgi?id=172503 https://bugs.webkit.org/show_bug.cgi?id=172212 https://bugs.webkit.org/show_bug.cgi?id=172611

Description Matt Lewis 2017-05-23 11:33:16 PDT

The test imported/w3c/web-platform-tests/css/css-display-3/display-contents-dynamic-flex-002-inline.html is a consistent Image failure.
The test is also crashing on Sierra WK1 Debug and iOS Simulator Debug.

The test was newly imported with:
https://trac.webkit.org/changeset/217280/webkit

The test has been failing since being imported

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-display-3%2Fdisplay-contents-dynamic-flex-002-inline.html

https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK2%20(Tests)/builds/1704
https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r217280%20(1704)/results.html

Crash:
HOULD NEVER BE REACHED
/Volumes/Data/slave/sierra-debug/build/Source/WebCore/rendering/RenderElement.cpp(524) : void WebCore::RenderElement::insertChildInternal(WebCore::RenderObject *, WebCore::RenderObject *, WebCore::RenderElement::NotifyChildrenType)
1   0x1048418dd WTFCrash
2   0x10fe60fbf WebCore::RenderElement::insertChildInternal(WebCore::RenderObject*, WebCore::RenderObject*, WebCore::RenderElement::NotifyChildrenType)
3   0x10fe60cb3 WebCore::RenderElement::addChild(WebCore::RenderObject*, WebCore::RenderObject*)
4   0x10fec158f WebCore::RenderInline::addChildIgnoringContinuation(WebCore::RenderObject*, WebCore::RenderObject*)
5   0x10fec1056 WebCore::RenderInline::addChild(WebCore::RenderObject*, WebCore::RenderObject*)
6   0x1100e1b01 WebCore::RenderTreePosition::insert(WebCore::RenderObject&)
7   0x1100e0f1c WebCore::RenderTreeUpdater::createRenderer(WebCore::Element&, WebCore::RenderStyle&&)
8   0x1100dfcdf WebCore::RenderTreeUpdater::updateElementRenderer(WebCore::Element&, WebCore::Style::ElementUpdate const&)
9   0x1100df5dc WebCore::RenderTreeUpdater::updateRenderTree(WebCore::ContainerNode&)
10  0x1100df017 WebCore::RenderTreeUpdater::commit(std::__1::unique_ptr<WebCore::Style::Update const, std::__1::default_delete<WebCore::Style::Update const> >)
11  0x10e2688cc WebCore::Document::resolveStyle(WebCore::Document::ResolveStyleType)
12  0x10e25b4f1 WebCore::Document::updateStyleIfNeeded()
13  0x10dff9cbd WebCore::updateStyleIfNeededForProperty(WebCore::Element&, WebCore::CSSPropertyID)
14  0x10dfec7a1 WebCore::ComputedStyleExtractor::propertyValue(WebCore::CSSPropertyID, WebCore::EUpdateLayout)
15  0x10dfec645 WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue(WebCore::CSSPropertyID, WebCore::EUpdateLayout) const
16  0x10e00a1da WebCore::CSSComputedStyleDeclaration::getPropertyCSSValueInternal(WebCore::CSSPropertyID)
17  0x10ed9ff42 WebCore::stylePropertyGetter(JSC::ExecState&, WebCore::JSCSSStyleDeclaration&, WebCore::CSSPropertyID)
18  0x10ed9c933 WebCore::stylePropertyGetter(JSC::ExecState&, WebCore::JSCSSStyleDeclaration&, WebCore::CSSPropertyInfo const&)
19  0x10ed9c2fc WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&)
20  0x10ed96e86 WebCore::JSCSSStyleDeclaration::getOwnPropertySlot(JSC::JSObject*, JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&)
21  0x10357a55a JSC::JSObject::getNonIndexPropertySlot(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&)
22  0x103578c76 JSC::JSObject::getPropertySlot(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&)
23  0x1035787e7 JSC::JSValue::getPropertySlot(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) const
24  0x103578645 JSC::JSValue::get(JSC::ExecState*, JSC::PropertyName, JSC::PropertySlot&) const
25  0x1043851f4 llint_slow_path_get_by_id
26  0x104396f38 llint_entry
27  0x10439b3b1 llint_entry
28  0x104393c6e vmEntryToJavaScript
29  0x1041636de JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*)
30  0x104113f55 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&)
31  0x1038bd968 JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&)

Comment 1 Emilio Cobos Álvarez 2017-05-23 11:58:58 PDT

What's the best way to deal with a test that crashes in debug mode but is an ImageOnlyFailure in release, just mark it with both expectations like [ Crash ImageOnlyFailure ]?

If so, happy to do so.

Comment 2 Matt Lewis 2017-05-23 14:31:45 PDT

Went ahead and marked the test for you. Marked it as Image only failure and crash. 

https://trac.webkit.org/changeset/217301/webkit/

Comment 3 Emilio Cobos Álvarez 2017-05-23 15:00:23 PDT

Oh, awesome, thanks for that!