Bug 172501

Summary: [preload] Conditional support for media preloading and align media `as` values.
Product: WebKit Reporter: Yoav Weiss <yoav>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, dbates, dino, japhet, sam, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Archive of layout-test-results from ews112 for mac-elcapitan
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch
none
Archive of layout-test-results from ews126 for ios-simulator-wk2
none
Patch
none
Patch
none
Patch
none
Patch none

Description Yoav Weiss 2017-05-23 04:29:34 PDT
[preload] Remove support for media preloading.
Comment 1 Yoav Weiss 2017-05-23 04:32:46 PDT
Created attachment 310995 [details]
Patch
Comment 2 Yoav Weiss 2017-05-23 04:50:56 PDT
Created attachment 310999 [details]
Patch
Comment 3 Sam Weinig 2017-05-23 08:59:41 PDT
Rather than removing it, should it be made a setting?
Comment 4 youenn fablet 2017-05-23 09:07:59 PDT
A setting sounds good.
Comment 5 Yoav Weiss 2017-05-31 02:23:45 PDT
Do you want me to plumb the settings all the way to WebKit2/WebProcess/WebPage (like current experimental features, or should it just be an internal setting, turned off by default? Opting for the latter, but let me know if the former is desired.
Comment 6 Yoav Weiss 2017-05-31 02:51:53 PDT
Created attachment 311579 [details]
Patch
Comment 7 Build Bot 2017-05-31 04:29:54 PDT
Comment on attachment 311579 [details]
Patch

Attachment 311579 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3847461

New failing tests:
http/tests/preload/download_resources.html
http/tests/preload/onerror_event.html
http/tests/preload/single_download_preload.html
http/wpt/preload/type-attribute.html
http/tests/preload/onload_event.html
Comment 8 Build Bot 2017-05-31 04:29:55 PDT
Created attachment 311581 [details]
Archive of layout-test-results from ews112 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 9 Build Bot 2017-05-31 05:20:04 PDT
Comment on attachment 311579 [details]
Patch

Attachment 311579 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3847648

New failing tests:
compositing/masks/compositing-clip-path-change-no-repaint.html
Comment 10 Build Bot 2017-05-31 05:20:05 PDT
Created attachment 311582 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 11 Yoav Weiss 2017-05-31 05:56:28 PDT
Created attachment 311583 [details]
Patch
Comment 12 Build Bot 2017-05-31 08:26:53 PDT
Comment on attachment 311583 [details]
Patch

Attachment 311583 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3848371

New failing tests:
fast/css/target-fragment-match.html
Comment 13 Build Bot 2017-05-31 08:26:55 PDT
Created attachment 311592 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 14 youenn fablet 2017-05-31 11:55:10 PDT
Could you turn the flag on for layout tests. Need to update WTR and DYR.
This should remove the need to change the tests.
You can see some examples with options like ice candidate filtering which is off by default but on with DYR/WTR
Comment 15 Sam Weinig 2017-05-31 14:57:56 PDT
(In reply to Yoav Weiss from comment #5)
> Do you want me to plumb the settings all the way to
> WebKit2/WebProcess/WebPage (like current experimental features, or should it
> just be an internal setting, turned off by default? Opting for the latter,
> but let me know if the former is desired.

Just something in Settings.in should suffice, since that can be triggered by the tests.
Comment 16 Yoav Weiss 2017-06-01 03:02:45 PDT
Created attachment 311686 [details]
Patch
Comment 17 Yoav Weiss 2017-06-01 05:57:16 PDT
Created attachment 311694 [details]
Patch
Comment 18 Yoav Weiss 2017-06-01 22:30:47 PDT
Created attachment 311806 [details]
Patch
Comment 19 Yoav Weiss 2017-06-02 00:05:24 PDT
Bots are now green and happy. PTAL?
Comment 20 Yoav Weiss 2017-06-06 13:04:58 PDT
Comment on attachment 311806 [details]
Patch

Thanks for reviewing! :)
Comment 21 WebKit Commit Bot 2017-06-06 13:05:45 PDT
Comment on attachment 311806 [details]
Patch

Rejecting attachment 311806 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 311806, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
der.php
patching file LayoutTests/http/tests/preload/resources/nph-invalid_resources_from_header.pl
patching file LayoutTests/http/tests/preload/single_download_preload.html
patching file LayoutTests/http/tests/preload/single_download_preload_headers.php
patching file LayoutTests/http/tests/preload/single_download_preload_headers_charset.php

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Dean Jackson']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3883376
Comment 22 Yoav Weiss 2017-06-06 14:54:19 PDT
Created attachment 312125 [details]
Patch
Comment 23 WebKit Commit Bot 2017-06-06 15:36:31 PDT
Comment on attachment 312125 [details]
Patch

Clearing flags on attachment: 312125

Committed r217863: <http://trac.webkit.org/changeset/217863>
Comment 24 WebKit Commit Bot 2017-06-06 15:36:33 PDT
All reviewed patches have been landed.  Closing bug.