Bug 172499

Summary:

Remove support for custom system backdrops

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

bfulgham, buildbot, graouts, rniwa, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews107 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
patch	buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews112 for mac-elcapitan	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none

Antti Koivisto

Reported 2017-05-23 03:36:12 PDT

Antoine says we don't need this anymore (soonish).

Attachments
patch (37.84 KB, patch) 2017-05-23 03:44 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (412.26 KB, application/zip) 2017-05-23 04:37 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews107 for mac-elcapitan-wk2 (489.84 KB, application/zip) 2017-05-23 04:40 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (431.03 KB, application/zip) 2017-05-23 04:43 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews125 for ios-simulator-wk2 (706.88 KB, application/zip) 2017-05-23 04:58 PDT, Build Bot	no flags	Details
patch (38.26 KB, patch) 2017-05-23 05:22 PDT, Antti Koivisto	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (1.51 MB, application/zip) 2017-05-23 06:29 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.51 MB, application/zip) 2017-05-23 06:36 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews112 for mac-elcapitan (2.20 MB, application/zip) 2017-05-23 06:50 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (14.43 MB, application/zip) 2017-05-23 06:57 PDT, Build Bot	no flags	Details
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Antti Koivisto

Comment 1 2017-05-23 03:41:47 PDT

This is -webkit-appearance: media-controls-dark-bar-background -webkit-appearance: media-controls-light-bar-background

Antti Koivisto

Comment 2 2017-05-23 03:44:25 PDT

Created attachment 310993 [details] patch

Build Bot

Comment 3 2017-05-23 04:37:23 PDT

Comment on attachment 310993 [details] patch Attachment 310993 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3799735 Number of test failures exceeded the failure limit.

Build Bot

Comment 4 2017-05-23 04:37:24 PDT

Created attachment 310996 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-05-23 04:40:55 PDT

Comment on attachment 310993 [details] patch Attachment 310993 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3799740 Number of test failures exceeded the failure limit.

Build Bot

Comment 6 2017-05-23 04:40:56 PDT

Created attachment 310997 [details] Archive of layout-test-results from ews107 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-05-23 04:43:15 PDT

Comment on attachment 310993 [details] patch Attachment 310993 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3799731 Number of test failures exceeded the failure limit.

Build Bot

Comment 8 2017-05-23 04:43:17 PDT

Created attachment 310998 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-05-23 04:58:41 PDT

Comment on attachment 310993 [details] patch Attachment 310993 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3799773 Number of test failures exceeded the failure limit.

Build Bot

Comment 10 2017-05-23 04:58:42 PDT

Created attachment 311000 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Antti Koivisto

Comment 11 2017-05-23 05:22:33 PDT

Created attachment 311001 [details] patch

Build Bot

Comment 12 2017-05-23 06:28:59 PDT

Comment on attachment 311001 [details] patch Attachment 311001 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3800151 New failing tests: media/modern-media-controls/start-button/start-button-styles.html

Build Bot

Comment 13 2017-05-23 06:29:00 PDT

Created attachment 311003 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 14 2017-05-23 06:35:59 PDT

Comment on attachment 311001 [details] patch Attachment 311001 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3800168 New failing tests: media/modern-media-controls/start-button/start-button-styles.html

Build Bot

Comment 15 2017-05-23 06:36:01 PDT

Created attachment 311004 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Antoine Quint

Comment 16 2017-05-23 06:36:53 PDT

Wouldn't worry too much about modern-media-controls tests, these are about to be skipped with https://bugs.webkit.org/show_bug.cgi?id=172447.

Build Bot

Comment 17 2017-05-23 06:50:03 PDT

Comment on attachment 311001 [details] patch Attachment 311001 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3800177 New failing tests: media/modern-media-controls/start-button/start-button-styles.html

Build Bot

Comment 18 2017-05-23 06:50:05 PDT

Created attachment 311005 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 19 2017-05-23 06:57:46 PDT

Comment on attachment 311001 [details] patch Attachment 311001 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3800185 New failing tests: media/modern-media-controls/start-button/start-button-styles.html platform/ios/media/video-play-glyph-composited-outside-overflow-scrolling-touch-container.html

Build Bot

Comment 20 2017-05-23 06:57:48 PDT

Created attachment 311006 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Simon Fraser (smfr)

Comment 21 2017-05-23 08:31:22 PDT

I guess I don't need to fix the visibility:hidden thing with them then?

Antti Koivisto

Comment 22 2017-05-23 09:09:22 PDT

No unless the media control plans change I suppose.

Radar WebKit Bug Importer

Comment 23 2017-05-23 10:20:41 PDT

<rdar://problem/32354075>

Note You need to log in before you can comment on or make changes to this bug.