Bug 172492

Summary: [GTK] Web Inspector: Add a new icon DockLeft.svg
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: Web InspectorAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: agomez, bugs-noreply, cgarcia, commit-queue, inspector-bugzilla-changes, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
screenshot of before and after this fix (RTL is specified) none

Fujii Hironori
Reported 2017-05-22 23:39:07 PDT
[GTK] Web Inspector: Add a new icon DockLeft.svg Apple's proprietary icon has added in Bug 168273.
Attachments
Patch (1.94 KB, patch)
2017-05-22 23:45 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
screenshot of before and after this fix (RTL is specified) (13.83 KB, image/png)
2017-05-22 23:51 PDT, Fujii Hironori 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2017-05-22 23:44:31 PDT
This icon can not be shown in the current GTK port because WebCore::UserInterfaceLayoutDirection::LTR is hard-coded in Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h at the moment.
Fujii Hironori
Comment 2 2017-05-22 23:45:17 PDT
Created attachment 310984 [details] Patch
Fujii Hironori
Comment 3 2017-05-22 23:51:16 PDT
Created attachment 310985 [details] screenshot of before and after this fix (RTL is specified)
WebKit Commit Bot
Comment 4 2017-05-23 00:21:24 PDT
Comment on attachment 310984 [details] Patch Clearing flags on attachment: 310984 Committed r217271: <http://trac.webkit.org/changeset/217271>
WebKit Commit Bot
Comment 5 2017-05-23 00:21:26 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 6 2017-05-23 06:33:59 PDT
(In reply to Fujii Hironori from comment #1) > This icon can not be shown in the current GTK port because > WebCore::UserInterfaceLayoutDirection::LTR is hard-coded in > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.h at the moment. Strange. Getting the text direction should be trivial: that's one call to gtk_widget_get_direction() on the WebKitWebView. Or if PageClientImpl doesn't have easy access to the WebKitWebView, a call to gtk_widget_get_default_direction() would work properly 99% of the time.
Note You need to log in before you can comment on or make changes to this bug.