Bug 172478

Summary: Rename DisplaySleepDisabler -> SleepDisabler
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Jer Noble
Reported 2017-05-22 16:05:46 PDT
Rename DisplaySleepDisabler -> SleepDisabler
Attachments
Patch (25.91 KB, patch)
2017-05-22 16:31 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (30.34 KB, patch)
2017-05-22 16:44 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch for landing (40.64 KB, patch)
2017-05-24 09:02 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-05-22 16:31:01 PDT
Created attachment 310950 [details] Patch
Jer Noble
Comment 2 2017-05-22 16:44:12 PDT
Created attachment 310955 [details] Patch
Sam Weinig
Comment 3 2017-05-22 17:48:27 PDT
Comment on attachment 310955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310955&action=review > Source/WebCore/ChangeLog:3 > + Rename DisplaySleepDisabler -> SleepDisabler Seems fine, but could have an explanation of why?
Jer Noble
Comment 4 2017-05-22 18:45:35 PDT
(In reply to Sam Weinig from comment #3) > Comment on attachment 310955 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=310955&action=review > > > Source/WebCore/ChangeLog:3 > > + Rename DisplaySleepDisabler -> SleepDisabler > > Seems fine, but could have an explanation of why? Sure. In a future patch, I’m going to allow clients to distinguish between display sleep and system sleep. I’ll add it to the change log before landing.
Jer Noble
Comment 5 2017-05-24 09:02:21 PDT
Created attachment 311122 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-05-24 09:40:00 PDT
Comment on attachment 311122 [details] Patch for landing Clearing flags on attachment: 311122 Committed r217371: <http://trac.webkit.org/changeset/217371>
WebKit Commit Bot
Comment 7 2017-05-24 09:40:02 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-05-30 20:27:30 PDT
<rdar://problem/32479834>
Note You need to log in before you can comment on or make changes to this bug.