Summary: | Rename DisplaySleepDisabler -> SleepDisabler | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jer Noble <jer.noble> | ||||||||
Component: | New Bugs | Assignee: | Jer Noble <jer.noble> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, sam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Jer Noble
2017-05-22 16:05:46 PDT
Created attachment 310950 [details]
Patch
Created attachment 310955 [details]
Patch
Comment on attachment 310955 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310955&action=review > Source/WebCore/ChangeLog:3 > + Rename DisplaySleepDisabler -> SleepDisabler Seems fine, but could have an explanation of why? (In reply to Sam Weinig from comment #3) > Comment on attachment 310955 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=310955&action=review > > > Source/WebCore/ChangeLog:3 > > + Rename DisplaySleepDisabler -> SleepDisabler > > Seems fine, but could have an explanation of why? Sure. In a future patch, I’m going to allow clients to distinguish between display sleep and system sleep. I’ll add it to the change log before landing. Created attachment 311122 [details]
Patch for landing
Comment on attachment 311122 [details] Patch for landing Clearing flags on attachment: 311122 Committed r217371: <http://trac.webkit.org/changeset/217371> All reviewed patches have been landed. Closing bug. |