Web Inspector: use initialLayout for NetworkSidebarPanel

• Component: Web Inspector
• Status: RESOLVED FIXED

[Devin Rousso]

Also move the creation of the NetworkGridContentView to right before it is shown.

[Devin Rousso]

Created attachment 310910 [details]
Patch

[Devin Rousso]

Created attachment 310912 [details]
[Image] Timeline Before

[Devin Rousso]

Created attachment 310913 [details]
[Image] Timeline After

[Joseph Pecoraro]

Comment on attachment 310910 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310910&action=review

r=me, but with concerns

> Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js:41
>          this.contentBrowser.addEventListener(WebInspector.ContentBrowser.Event.CurrentContentViewDidChange, this._contentBrowserCurrentContentViewDidChange, this);

As was mentioned previously, it doesn't make sense to me why this is not in initialLayout. It seems potentially problematic keeping it separate. It is quite small right now but I do worry about future changes adding code in there that is unsafe unless performed after initial layout.

> Source/WebInspectorUI/UserInterface/Views/NetworkSidebarPanel.js:82
> +        var scopeItemPrefix = "network-sidebar-";

Style: Lets upgrade these to `let` now.

[Devin Rousso]

Created attachment 311042 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 311042 [details]
Patch

Clearing flags on attachment: 311042

Committed r217295: <http://trac.webkit.org/changeset/217295>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.