Summary: | [ThreadedCompositor] Improve composition and update state handling | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zan Dobersek <zan> | ||||||||
Component: | New Bugs | Assignee: | Zan Dobersek <zan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, cgarcia, magomez, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Zan Dobersek
2017-05-22 07:32:41 PDT
Created attachment 310868 [details]
WIP
Created attachment 317691 [details]
WIP
Needs comments, ChangeLog.
Created attachment 317924 [details]
Patch
Attachment 317924 [details] did not pass style-queue:
ERROR: Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:362: This { should be at the end of the previous line [whitespace/braces] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 317924 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317924&action=review Excellent comments, it's a lot easier to follow now. Thanks! > Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:186 > +void CompositingRunLoop::compositionCompleted(LockHolder& stateLocker) Why does this receive the lock if it's unused, is it just to make sure the caller always calls this with the lock held? (In reply to Carlos Garcia Campos from comment #5) > > Source/WebKit/Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:186 > > +void CompositingRunLoop::compositionCompleted(LockHolder& stateLocker) > > Why does this receive the lock if it's unused, is it just to make sure the > caller always calls this with the lock held? Yes, that's the reason. Comment on attachment 317924 [details] Patch Clearing flags on attachment: 317924 Committed r220672: <http://trac.webkit.org/changeset/220672> All reviewed patches have been landed. Closing bug. |