| Summary: | [Modern Media Controls] Turn off all tests | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||||||
| Component: | Media | Assignee: | Antoine Quint <graouts> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, jbedard, jonlee, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| See Also: | https://bugs.webkit.org/show_bug.cgi?id=182482 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Antoine Quint
2017-05-22 07:32:06 PDT
Created attachment 310867 [details]
Patch
Created attachment 311002 [details]
Patch for landing
Comment on attachment 311002 [details] Patch for landing Rejecting attachment 311002 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 311002, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ster/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 217272 = a266d030e8388ce0dcb658b42aaf952012f0bbab r217273 = 8e999b93e03c3500417106bde312d216801030b7 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. ERROR: LayoutTests/TestExpectations:1281: Path does not exist. [test/expectations] [5] Total errors found: 1 in 1 files Full output: http://webkit-queues.webkit.org/results/3800384 Created attachment 311007 [details]
Patch for landing
Comment on attachment 311007 [details] Patch for landing Clearing flags on attachment: 311007 Committed r217275: <http://trac.webkit.org/changeset/217275> All reviewed patches have been landed. Closing bug. Where are we tracking the work for the 'more permanent solution'? We shouldn't just keep these tests disabled, especially because at this point, they are only partially disabled. Many modern-media-controls tests are enabled. A big underlying problem has been identified and fixed a while back, I'm hoping to turn more tests back on this week, if not all of them. These are being turned back on with https://bugs.webkit.org/show_bug.cgi?id=182482. |