Bug 172447

Summary:

[Modern Media Controls] Turn off all tests

Product:

WebKit

Reporter:

Antoine Quint <graouts>

Component:

Media

Assignee:

Antoine Quint <graouts>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jbedard, jonlee, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

See Also:

https://bugs.webkit.org/show_bug.cgi?id=182482

Attachments:

Description	Flags
Patch	none
Patch for landing	none
Patch for landing	none

Antoine Quint

Reported 2017-05-22 07:32:06 PDT

Due to the high number of timeouts and random failures with the current tests, we turn off all modern-media-controls tests while we wait on a more permanent solution.

Attachments
Patch (18.13 KB, patch) 2017-05-22 07:33 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch for landing (18.16 KB, patch) 2017-05-23 06:20 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Patch for landing (18.97 KB, patch) 2017-05-23 07:02 PDT, Antoine Quint	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-05-22 07:32:25 PDT

<rdar://problem/32325772>

Antoine Quint

Comment 2 2017-05-22 07:33:14 PDT

Created attachment 310867 [details] Patch

Antoine Quint

Comment 3 2017-05-23 06:20:27 PDT

Created attachment 311002 [details] Patch for landing

WebKit Commit Bot

Comment 4 2017-05-23 06:58:43 PDT

Comment on attachment 311002 [details] Patch for landing Rejecting attachment 311002 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 311002, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ster/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 217272 = a266d030e8388ce0dcb658b42aaf952012f0bbab r217273 = 8e999b93e03c3500417106bde312d216801030b7 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. ERROR: LayoutTests/TestExpectations:1281: Path does not exist. [test/expectations] [5] Total errors found: 1 in 1 files Full output: http://webkit-queues.webkit.org/results/3800384

Antoine Quint

Comment 5 2017-05-23 07:02:59 PDT

Created attachment 311007 [details] Patch for landing

WebKit Commit Bot

Comment 6 2017-05-23 07:18:58 PDT

Comment on attachment 311007 [details] Patch for landing Clearing flags on attachment: 311007 Committed r217275: <http://trac.webkit.org/changeset/217275>

WebKit Commit Bot

Comment 7 2017-05-23 07:18:59 PDT

All reviewed patches have been landed. Closing bug.

Jonathan Bedard

Comment 8 2018-01-29 09:42:02 PST

Where are we tracking the work for the 'more permanent solution'? We shouldn't just keep these tests disabled, especially because at this point, they are only partially disabled. Many modern-media-controls tests are enabled.

Antoine Quint

Comment 9 2018-01-29 11:45:16 PST

A big underlying problem has been identified and fixed a while back, I'm hoping to turn more tests back on this week, if not all of them.

Antoine Quint

Comment 10 2018-02-05 08:26:36 PST

These are being turned back on with https://bugs.webkit.org/show_bug.cgi?id=182482.

Note You need to log in before you can comment on or make changes to this bug.