Bug 172433

Summary: Do no enter Subversion-specific logic when parsing Git-based Trac data.
Product: WebKit Reporter: Jason Marcell <jmarcell>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: kocsen_chung, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch ap: review+

Description Jason Marcell 2017-05-21 17:46:45 PDT
Do no enter Subversion-specific logic when parsing Git-based Trac data.
Comment 1 Jason Marcell 2017-05-21 17:47:52 PDT
Created attachment 310822 [details]
Patch
Comment 2 Jason Marcell 2017-05-21 17:49:49 PDT
Created attachment 310823 [details]
Patch
Comment 3 Alexey Proskuryakov 2017-05-21 18:20:43 PDT
Comment on attachment 310823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310823&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:182
> +        // Note: we have an overidden timeline.rss that adds git branches to the Trac timeline RSS output (rdar://problem/23853623)

I suggest removing "Note:", as every comment is a note. Please also add a period in the end to make it a proper sentence.
Comment 4 Kocsen Chung 2017-05-22 09:34:31 PDT
👍, thanks Jason.