Summary: | Web Inspector: Using "break on all exceptions" when throwing stack overflow hangs inspector | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> | ||||||||
Component: | Web Inspector | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, commit-queue, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, mattbaker, msaboff | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Saam Barati
2017-05-21 16:06:17 PDT
Created attachment 313459 [details]
[PATCH] Proposed Fix v4
Comment on attachment 313459 [details]
[PATCH] Proposed Fix v4
r=me
Can you add a test that ensures we don't catch it in inspector?
Comment on attachment 313459 [details]
[PATCH] Proposed Fix v4
Oops, yes I totally meant to add a test.
Created attachment 313546 [details]
[PATCH] Proposed Fix - With Tests
Comment on attachment 313546 [details] [PATCH] Proposed Fix - With Tests View in context: https://bugs.webkit.org/attachment.cgi?id=313546&action=review > LayoutTests/inspector/debugger/no-pause-stack-overflow-exception.html:21 > + WebInspector.debuggerManager.assertionsBreakpoint.disabled = false; I can drop the assertions breakpoint. I really just need the all exceptions one. Created attachment 313547 [details]
[PATCH] Proposed Fix - With Tests
Comment on attachment 313547 [details] [PATCH] Proposed Fix - With Tests Clearing flags on attachment: 313547 Committed r218652: <http://trac.webkit.org/changeset/218652> All reviewed patches have been landed. Closing bug. |