Bug 172423

Summary:

Merge split script tests

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, ddkilzer, fpizlo, lforschler, ossy, rniwa, sam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

172584

Bug Blocks:

Attachments:

Description	Flags
patch for EWS	none
patch for EWS	none
patch for EWS	buildbot: commit-queue-
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews115 for mac-elcapitan	none
Archive of layout-test-results from ews122 for ios-simulator-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
proposed patch	none
proposed patch	none
proposed patch	none
part 2	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none

Alexey Proskuryakov

Reported 2017-05-20 16:05:18 PDT

In the past, many tests were being split into HTML and JS parts for no good reason. This makes it hard to see what those tests are doing.

Attachments
patch for EWS (8.23 MB, patch) 2017-05-20 16:08 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
patch for EWS (6.65 MB, patch) 2017-05-20 22:11 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
patch for EWS (6.56 MB, patch) 2017-05-21 16:57 PDT, Alexey Proskuryakov	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews101 for mac-elcapitan (1.04 MB, application/zip) 2017-05-21 18:24 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1012.74 KB, application/zip) 2017-05-21 18:28 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews115 for mac-elcapitan (1.83 MB, application/zip) 2017-05-21 18:42 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (983.73 KB, application/zip) 2017-05-21 19:12 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.01 MB, application/zip) 2017-05-21 20:52 PDT, Build Bot	no flags	Details
proposed patch (8.24 MB, patch) 2017-05-22 12:23 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
proposed patch (6.57 MB, patch) 2017-05-23 23:15 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
proposed patch (6.57 MB, patch) 2017-05-23 23:53 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
part 2 (198.33 KB, patch) 2017-05-24 23:12 PDT, Alexey Proskuryakov	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (10.88 MB, application/zip) 2017-05-25 00:37 PDT, Build Bot	no flags	Details
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Alexey Proskuryakov

Comment 1 2017-05-20 16:08:41 PDT

Created attachment 310784 [details] patch for EWS

Alexey Proskuryakov

Comment 2 2017-05-20 22:11:33 PDT

Created attachment 310794 [details] patch for EWS

Alexey Proskuryakov

Comment 3 2017-05-21 16:57:58 PDT

Created attachment 310821 [details] patch for EWS

Build Bot

Comment 4 2017-05-21 18:24:51 PDT

Comment on attachment 310821 [details] patch for EWS Attachment 310821 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3791451 New failing tests: fast/regex/dom/cross-frame-callable.html fast/parser/double-write-from-closed-iframe.html fast/dom/Geolocation/notimer-after-unload.html fast/dom/Window/invalid-protocol.html fast/dom/dataset-xhtml.xhtml fast/dom/javascript-url-exception-isolation.html svg/custom/poly-parsing-error.html fast/text/find-russian.html fast/dom/webtiming-document-open.html svg/dom/path-parser.html fast/dom/Geolocation/callback-exception.html fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html fast/parser/fragment-parser.html

Build Bot

Comment 5 2017-05-21 18:24:52 PDT

Created attachment 310824 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-05-21 18:28:36 PDT

Created attachment 310825 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-05-21 18:42:33 PDT

Comment on attachment 310821 [details] patch for EWS Attachment 310821 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3791455 New failing tests: fast/dom/Window/invalid-protocol.html fast/parser/double-write-from-closed-iframe.html fast/dom/Geolocation/notimer-after-unload.html fast/dom/dataset-xhtml.xhtml fast/dom/javascript-url-exception-isolation.html svg/custom/poly-parsing-error.html fast/text/find-russian.html fast/regex/dom/cross-frame-callable.html fast/dom/webtiming-document-open.html svg/dom/path-parser.html fast/dom/Geolocation/callback-exception.html fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html fast/parser/fragment-parser.html

Build Bot

Comment 8 2017-05-21 18:42:34 PDT

Created attachment 310826 [details] Archive of layout-test-results from ews115 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 9 2017-05-21 19:12:36 PDT

Comment on attachment 310821 [details] patch for EWS Attachment 310821 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3791479 New failing tests: fast/dom/Window/invalid-protocol.html fast/parser/double-write-from-closed-iframe.html fast/dom/Geolocation/notimer-after-unload.html fast/scrolling/ios/overflow-div-scrolling.html fast/dom/dataset-xhtml.xhtml fast/dom/javascript-url-exception-isolation.html svg/custom/poly-parsing-error.html fast/text/find-russian.html fast/regex/dom/cross-frame-callable.html fast/dom/webtiming-document-open.html svg/dom/path-parser.html fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html fast/parser/fragment-parser.html

Build Bot

Comment 10 2017-05-21 19:12:37 PDT

Created attachment 310827 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 11 2017-05-21 20:52:51 PDT

Comment on attachment 310821 [details] patch for EWS Attachment 310821 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3791848 New failing tests: fast/dom/HTMLScriptElement/script-for-attribute-unexpected-execution.html fast/dom/Window/invalid-protocol.html fast/parser/double-write-from-closed-iframe.html fast/dom/Geolocation/notimer-after-unload.html fast/dom/dataset-xhtml.xhtml fast/dom/javascript-url-exception-isolation.html svg/custom/poly-parsing-error.html fast/text/find-russian.html fast/regex/dom/cross-frame-callable.html fast/dom/webtiming-document-open.html svg/dom/path-parser.html fast/scrolling/ios/overflow-div-scrolling.html fast/dom/Geolocation/clear-watch-invalid-id-crash.html fast/parser/fragment-parser.html

Build Bot

Comment 12 2017-05-21 20:52:53 PDT

Created attachment 310830 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6

Alexey Proskuryakov

Comment 13 2017-05-22 12:23:43 PDT

Created attachment 310900 [details] proposed patch

Alexey Proskuryakov

Comment 14 2017-05-23 23:15:46 PDT

Created attachment 311104 [details] proposed patch

Alexey Proskuryakov

Comment 15 2017-05-23 23:53:37 PDT

Created attachment 311105 [details] proposed patch

Sam Weinig

Comment 16 2017-05-24 14:47:38 PDT

Comment on attachment 311105 [details] proposed patch Very nice!

WebKit Commit Bot

Comment 17 2017-05-24 16:00:13 PDT

Comment on attachment 311105 [details] proposed patch Clearing flags on attachment: 311105 Committed r217390: <http://trac.webkit.org/changeset/217390>

WebKit Commit Bot

Comment 18 2017-05-24 16:00:14 PDT

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 19 2017-05-24 23:12:25 PDT

Re-opening for part 2.

Alexey Proskuryakov

Comment 20 2017-05-24 23:12:41 PDT

Created attachment 311204 [details] part 2

David Kilzer (:ddkilzer)

Comment 21 2017-05-25 00:27:37 PDT

(In reply to WebKit Commit Bot from comment #17) > Comment on attachment 311105 [details] > proposed patch > > Clearing flags on attachment: 311105 > > Committed r217390: <http://trac.webkit.org/changeset/217390> This broken internal Production builds that had a build step that called Tools/Scripts/run-jsc-stress-tests, which read LayoutTests/jsc-layout-tests.yaml, which references fast/regex/script-tests.

Build Bot

Comment 22 2017-05-25 00:37:42 PDT

Comment on attachment 311204 [details] part 2 Attachment 311204 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3811321 New failing tests: fetch/closing-while-fetching-blob.html

Build Bot

Comment 23 2017-05-25 00:37:44 PDT

Created attachment 311208 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

David Kilzer (:ddkilzer)

Comment 24 2017-05-25 00:42:37 PDT

(In reply to David Kilzer (:ddkilzer) from comment #21) > (In reply to WebKit Commit Bot from comment #17) > > Comment on attachment 311105 [details] > > proposed patch > > > > Clearing flags on attachment: 311105 > > > > Committed r217390: <http://trac.webkit.org/changeset/217390> > > This broken internal Production builds that had a build step that called > Tools/Scripts/run-jsc-stress-tests, which read > LayoutTests/jsc-layout-tests.yaml, which references fast/regex/script-tests. I rolled out changes to LayoutTests/fast/regex/ from r217390 here: Bug 172584: REGRESSION(r217390): "Broke internal Production builds that ran run-jsc-stress-tests" (Requested by ddkilzer on #webkit). <https://bugs.webkit.org/show_bug.cgi?id=172584> <http://trac.webkit.org/changeset/217408>

Csaba Osztrogonác

Comment 25 2017-05-25 03:11:28 PDT

(In reply to David Kilzer (:ddkilzer) from comment #21) > (In reply to WebKit Commit Bot from comment #17) > > Comment on attachment 311105 [details] > > proposed patch > > > > Clearing flags on attachment: 311105 > > > > Committed r217390: <http://trac.webkit.org/changeset/217390> > > This broken internal Production builds that had a build step that called > Tools/Scripts/run-jsc-stress-tests, which read > LayoutTests/jsc-layout-tests.yaml, which references fast/regex/script-tests. Not only the internal tests, but all JSC bots on build.webkit.org waterfall.

Alexey Proskuryakov

Comment 26 2017-05-25 09:47:45 PDT

Thanks! I didn't touch js and imported, but had no idea that fast/regex was also special. It should probably be moved inside js then.

Tim Horton

Comment 27 2017-05-25 18:37:49 PDT

Comment on attachment 311204 [details] part 2 rs=me

WebKit Commit Bot

Comment 28 2017-05-25 19:10:37 PDT

Comment on attachment 311204 [details] part 2 Clearing flags on attachment: 311204 Committed r217466: <http://trac.webkit.org/changeset/217466>

WebKit Commit Bot

Comment 29 2017-05-25 19:10:39 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 30 2017-05-30 20:30:10 PDT

<rdar://problem/32479864>

Note You need to log in before you can comment on or make changes to this bug.