Bug 172417

Summary: [JSC] Drop MapBase
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, saam, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Yusuke Suzuki
Reported 2017-05-20 11:23:32 PDT
[JSC] Drop MapBase
Attachments
Patch (28.24 KB, patch)
2017-05-20 11:25 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-05-20 11:25:13 PDT
Created attachment 310776 [details] Patch
Sam Weinig
Comment 2 2017-05-20 11:54:28 PDT
Comment on attachment 310776 [details] Patch Very nice. Any idea why the indirection was there in the first place? Was this from a time when the HashMap wasn't a JSCell?
Yusuke Suzuki
Comment 3 2017-05-20 12:38:14 PDT
Comment on attachment 310776 [details] Patch Discussed with Saam at IRC (private message). We guess that this is accidentally introduced.
WebKit Commit Bot
Comment 4 2017-05-20 13:07:26 PDT
Comment on attachment 310776 [details] Patch Clearing flags on attachment: 310776 Committed r217192: <http://trac.webkit.org/changeset/217192>
WebKit Commit Bot
Comment 5 2017-05-20 13:07:27 PDT
All reviewed patches have been landed. Closing bug.
Saam Barati
Comment 6 2017-05-20 15:23:08 PDT
(In reply to Sam Weinig from comment #2) > Comment on attachment 310776 [details] > Patch > > Very nice. Any idea why the indirection was there in the first place? Was > this from a time when the HashMap wasn't a JSCell? There isn’t a goood reason. When I rewrote our map/set implementation last year I just left this in.
Note You need to log in before you can comment on or make changes to this bug.