Bug 172398

Summary:

Many WebAudio js-tests use waitUntilDone

Product:

WebKit

Reporter:

Alexey Proskuryakov <ap>

Component:

Tools / Tests

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jer.noble, lforschler, sam, thorton

Priority:

Version:

Safari 9

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

168961

Attachments:

Description	Flags
proposed patch	none

Description Alexey Proskuryakov 2017-05-19 16:10:26 PDT

js-tests are incompatible with testRunner.waitUntilDone(), yet there are hundreds of tests that mix these techniques.

The common symptom is that TEST COMPLETE is printed before the test is complete. But there may be more, including flakiness. Some of these tests are malformed in other ways, such as using js-test-pre.js without js-test-post.js.

Comment 1 Alexey Proskuryakov 2017-05-19 16:12:59 PDT

Created attachment 310720 [details]
proposed patch

Comment 2 Sam Weinig 2017-05-19 16:32:23 PDT

Comment on attachment 310720 [details]
proposed patch

rs=me

Comment 3 WebKit Commit Bot 2017-05-22 13:49:16 PDT

Comment on attachment 310720 [details]
proposed patch

Clearing flags on attachment: 310720

Committed r217243: <http://trac.webkit.org/changeset/217243>

Comment 4 WebKit Commit Bot 2017-05-22 13:49:17 PDT

All reviewed patches have been landed.  Closing bug.