Bug 172379

Summary: Many CSS js-tests use waitUntilDone
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, lforschler, simon.fraser, thorton, zalan
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 168961    
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2017-05-19 12:52:10 PDT
js-tests are incompatible with testRunner.waitUntilDone(), yet there are hundreds of tests that mix these techniques. The common symptom is that TEST COMPLETE is printed before the test is complete. But there may be more, including flakiness. Some of these tests are malformed in other ways, such as using js-test-pre.js without js-test-post.js.
Attachments
proposed patch (43.39 KB, patch)
2017-05-19 12:53 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2017-05-19 12:53:50 PDT
Created attachment 310686 [details] proposed patch
Tim Horton
Comment 2 2017-05-19 13:41:45 PDT
Comment on attachment 310686 [details] proposed patch rs=me
WebKit Commit Bot
Comment 3 2017-05-19 14:19:03 PDT
Comment on attachment 310686 [details] proposed patch Clearing flags on attachment: 310686 Committed r217150: <http://trac.webkit.org/changeset/217150>
WebKit Commit Bot
Comment 4 2017-05-19 14:19:05 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.