Bug 172372

Summary: Many accessibility js-tests use waitUntilDone
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, commit-queue, dbates, lforschler, thorton
Priority: P2    
Version: Safari 9   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 168961    
Attachments:
Description Flags
proposed patch none

Alexey Proskuryakov
Reported 2017-05-19 11:57:16 PDT
js-tests are incompatible with testRunner.waitUntilDone(), yet there are hundreds of tests that mix these techniques. The common symptom is that TEST COMPLETE is printed before the test is complete. But there may be more, including flakiness. Some of these tests are malformed in other ways, such as using js-test-pre.js without js-test-post.js.
Attachments
proposed patch (89.52 KB, patch)
2017-05-19 12:02 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2017-05-19 12:02:16 PDT
Created attachment 310681 [details] proposed patch
Tim Horton
Comment 2 2017-05-19 13:42:01 PDT
Comment on attachment 310681 [details] proposed patch rs=me
WebKit Commit Bot
Comment 3 2017-05-19 14:19:06 PDT
Comment on attachment 310681 [details] proposed patch Rejecting attachment 310681 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 310681, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: .webkit.org/git/WebKit dbd4584..7c5c449 master -> origin/master Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ... Currently at 217148 = dbd4584443870cc224a699c54c990aee659f7abc r217149 = 7c5c4496c93dce138fa915f47bf12790ad2b7f22 Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc First, rewinding head to replay your work on top of it... Fast-forwarded master to refs/remotes/origin/master. Full output: http://webkit-queues.webkit.org/results/3778831
WebKit Commit Bot
Comment 4 2017-05-19 16:38:03 PDT
Comment on attachment 310681 [details] proposed patch Clearing flags on attachment: 310681 Committed r217171: <http://trac.webkit.org/changeset/217171>
WebKit Commit Bot
Comment 5 2017-05-19 16:38:05 PDT
All reviewed patches have been landed. Closing bug.
Daniel Bates
Comment 6 2017-05-19 22:44:37 PDT
js-test.js is an out-of-date merge of js-test-pre.js and js-test-post.js.
Alexey Proskuryakov
Comment 7 2017-05-19 23:45:05 PDT
It's the better one to use in new tests. If some functions were only added to -pre, they should be added to js-test.js too.
Note You need to log in before you can comment on or make changes to this bug.