Summary: | Inspector should link console.{log,warn,info,error} back to call site | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Timothy Hatcher <timothy> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | keishi | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 14354 | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2008-02-08 13:56:26 PST
In general we have no way of knowing what line number the console.* method was called on. (In reply to comment #2) > In general we have no way of knowing what line number the console.* method was > called on. ...nor do we know what the URL of the script that made the call was. One way to solve this problem would be for console.log to use a special CallType that gets additional information passed to it when it's called as a function. Basically, this would require: * Add a new CallType to the CallType enum in JavaScriptCore * Make console.log's getCallData function return that CallType * Change the sites in JavaScriptCore that deal with CallType to handle this new CallType (I think there are about 4) *** Bug 19791 has been marked as a duplicate of this bug. *** (In reply to comment #4 at bug #19791) > I think using CustomCall for the Console object is fine. The majority of the > console functions want this info. > I tried doing "interface [CustomCall] Console {" but that doesn't seem to change the CallTypes for console.*. Calling console() seems to have the new custom CallType but that's not what I want. I talked with Geoff about how to get the line numbers and source files for more than just these functions. I think we are going to be taking this in another direction. Once that lands, these should be simple to implement. Created attachment 23116 [details]
Proposed patch
|