Bug 172329

Summary: webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') disagree.
Product: WebKit Reporter: Jeremy Jones <jeremyj-wk>
Component: MediaAssignee: Jeremy Jones <jeremyj-wk>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, darin, eric.carlson, jer.noble, jonlee, rniwa, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch for landing.
buildbot: commit-queue-
Archive of layout-test-results from ews102 for mac-elcapitan
none
Patch for landing. none

Jeremy Jones
Reported 2017-05-18 18:26:34 PDT
webkitSupportsFullscreen and webkitSupportsPresentationMode('fullscreen') disagree.
Attachments
Patch (1.81 KB, patch)
2017-05-18 18:30 PDT, Jeremy Jones 		darin: review+
DetailsFormatted DiffDiff
Patch for landing. (6.24 KB, patch)
2017-05-19 14:56 PDT, Jeremy Jones 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-elcapitan (1.10 MB, application/zip)
2017-05-19 15:38 PDT, Build Bot 		no flags
Details
Patch for landing. (9.95 KB, patch)
2017-05-19 15:58 PDT, Jeremy Jones 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jeremy Jones
Comment 1 2017-05-18 18:28:19 PDT
rdar://problem/32260891
Jeremy Jones
Comment 2 2017-05-18 18:30:40 PDT
Created attachment 310588 [details] Patch
Jon Lee
Comment 3 2017-05-18 20:00:41 PDT
Can we add a test, please?
Jeremy Jones
Comment 4 2017-05-19 14:56:56 PDT
Created attachment 310703 [details] Patch for landing.
Jeremy Jones
Comment 5 2017-05-19 14:57:53 PDT
(In reply to Jon Lee from comment #3) > Can we add a test, please? Updated a couple existing tests to test this functionality.
Build Bot
Comment 6 2017-05-19 15:38:03 PDT
Comment on attachment 310703 [details] Patch for landing. Attachment 310703 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3779152 New failing tests: media/media-fullscreen-inline.html
Build Bot
Comment 7 2017-05-19 15:38:04 PDT
Created attachment 310711 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Jeremy Jones
Comment 8 2017-05-19 15:57:16 PDT
Updating test expectation of El Capitan where there is no webkitSuppportsPresentationMode
Jeremy Jones
Comment 9 2017-05-19 15:58:51 PDT
Created attachment 310718 [details] Patch for landing.
WebKit Commit Bot
Comment 10 2017-05-19 17:27:36 PDT
Comment on attachment 310718 [details] Patch for landing. Clearing flags on attachment: 310718 Committed r217176: <http://trac.webkit.org/changeset/217176>
Note You need to log in before you can comment on or make changes to this bug.