Bug 172317

Summary: [CMake] Add HAVE check for __int128_t
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, lforschler, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172144    
Attachments:
Description Flags
Patch none

Don Olmstead
Reported 2017-05-18 15:05:46 PDT
CMake can be used to verify the presence of __int128_t.
Attachments
Patch (2.86 KB, patch)
2017-05-18 15:31 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-18 15:20:44 PDT
Blocks compilation of JSCOnly on Windows
Don Olmstead
Comment 2 2017-05-18 15:31:57 PDT
Created attachment 310558 [details] Patch This patch adds a HAVE check for __int128_t. I did not want to do a COMPILER check because clang-cl shows up as both Clang and MSVC so a HAVE check is the best choice. A patch for clang-cl support is coming in the near future. Currently GCC and Clang expose this. It appears this is exposed only on x64 according to GCC docs https://gcc.gnu.org/onlinedocs/gcc/_005f_005fint128.html. I also saw that clang-cl seems to have that behavior as it does not expose it for x86 builds but does for x64. I don't believe that the Intel compiler exposes this value in case anyone is using that. The Platform.h file is modified within the block that has all the corresponding HAVE checks in OptionsCommon. This is to support DARWIN targets that are not using CMake.
Yusuke Suzuki
Comment 3 2017-05-19 01:30:39 PDT
Comment on attachment 310558 [details] Patch r=me
WebKit Commit Bot
Comment 4 2017-05-19 01:58:33 PDT
Comment on attachment 310558 [details] Patch Clearing flags on attachment: 310558 Committed r217105: <http://trac.webkit.org/changeset/217105>
WebKit Commit Bot
Comment 5 2017-05-19 01:58:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.