Bug 172309

Summary:

Redundant ellipsis box triggers ASSERT_WITH_SECURITY_IMPLICATION in InlineBox::parent().

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, ryanhaddad, simon.fraser, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none

alan

Reported 2017-05-18 14:09:19 PDT

but in this case, it is not a security issue at all -not even an issue. rdar://problem/32262357

Attachments
Patch (7.76 KB, patch) 2017-05-18 16:18 PDT, alan	no flags	Details Formatted Diff Diff
Patch (7.77 KB, patch) 2017-05-18 16:57 PDT, alan	no flags	Details Formatted Diff Diff
Patch (7.80 KB, patch) 2017-05-19 08:04 PDT, alan	no flags	Details Formatted Diff Diff
Patch (7.88 KB, patch) 2017-05-19 15:13 PDT, alan	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2017-05-18 16:18:51 PDT

Created attachment 310571 [details] Patch

Simon Fraser (smfr)

Comment 2 2017-05-18 16:54:36 PDT

Comment on attachment 310571 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310571&action=review > Source/WebCore/rendering/InlineBox.h:416 > + bool m_inChildList { true }; Maybe call this m_isEverInChildList, or even m_isEllipsisBox.

alan

Comment 3 2017-05-18 16:57:44 PDT

Created attachment 310576 [details] Patch

WebKit Commit Bot

Comment 4 2017-05-18 17:37:47 PDT

Comment on attachment 310576 [details] Patch Clearing flags on attachment: 310576 Committed r217079: <http://trac.webkit.org/changeset/217079>

WebKit Commit Bot

Comment 5 2017-05-18 17:37:48 PDT

All reviewed patches have been landed. Closing bug.

Ryan Haddad

Comment 6 2017-05-18 20:23:34 PDT

(In reply to WebKit Commit Bot from comment #4) > Comment on attachment 310576 [details] > Patch > > Clearing flags on attachment: 310576 > > Committed r217079: <http://trac.webkit.org/changeset/217079> This change broke the Windows debug build, as well as some internal builds: https://build.webkit.org/builders/Apple%20Win%20Debug%20(Build)/builds/1419