Bug 172307

Summary: Make WebRTC logging happen in Release
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, krollin, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2017-05-18 13:05:44 PDT
This will allow easier debugging
Attachments
Patch (9.72 KB, patch)
2017-05-18 13:07 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2017-05-18 13:07:22 PDT
Created attachment 310540 [details] Patch
Simon Fraser (smfr)
Comment 2 2017-05-18 13:19:48 PDT
Comment on attachment 310540 [details] Patch This logging doesn't look useful. I don't see logging on any error conditions.
youenn fablet
Comment 3 2017-05-18 13:30:58 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 310540 [details] > Patch > > This logging doesn't look useful. I don't see logging on any error > conditions. This logging allows to see what are the parameters of the session. This is extremely useful when you are not controlling the website or the other endpoint. What we do not have here: - Whether the network connection is successful or not. This should be added as a follow-up. Useful when you are not sure of the network - The state of the network connection once successful. This might be perf sensitive but would be useful as long as we do not have some inspector functionality similar to chrome:://webrtc-internals. - Any media element state. This should also be added as a follow-up. Useful when we have issues with autoplay and such.
WebKit Commit Bot
Comment 4 2017-05-18 18:43:39 PDT
Comment on attachment 310540 [details] Patch Clearing flags on attachment: 310540 Committed r217082: <http://trac.webkit.org/changeset/217082>
WebKit Commit Bot
Comment 5 2017-05-18 18:43:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.