Bug 172297

Summary:

RealtimeOutgoingAudioSource should use the source sample rate

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

Media

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, eric.carlson, jonlee, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description youenn fablet 2017-05-18 11:21:27 PDT

Currently it expects the data to be 48000

Comment 1 youenn fablet 2017-05-18 11:23:50 PDT

Created attachment 310520 [details]
Patch

Comment 2 Eric Carlson 2017-05-18 11:38:16 PDT

Comment on attachment 310520 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310520&action=review

> Source/WebCore/ChangeLog:11
> +        (WebCore::RealtimeOutgoingAudioSource::audioSamplesAvailable): Using the audio source sample rate so that the converter does the right conversion.

Nit: this line is too long.
Nit: "Using" => "Use".

Comment 3 Radar WebKit Bug Importer 2017-05-18 11:41:02 PDT

<rdar://problem/32277335>

Comment 4 WebKit Commit Bot 2017-05-18 12:07:58 PDT

Comment on attachment 310520 [details]
Patch

Clearing flags on attachment: 310520

Committed r217058: <http://trac.webkit.org/changeset/217058>

Comment 5 WebKit Commit Bot 2017-05-18 12:07:59 PDT

All reviewed patches have been landed.  Closing bug.