Bug 172288

Summary: [Readable Streams API] Align respondInClosedState with spec
Product: WebKit Reporter: Romain Bellessort <romain.wkt>
Component: WebCore Misc.Assignee: Romain Bellessort <romain.wkt>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, nael.ouedp, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Romain Bellessort
Reported 2017-05-18 09:09:05 PDT
The issue reported to GH [1] while working on bug 168781 has now been fixed. WebKit implementation should be aligned with corresponding fix. [1] https://github.com/whatwg/streams/issues/686
Attachments
Patch (3.05 KB, patch)
2017-05-18 09:21 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Patch (3.26 KB, patch)
2017-05-23 07:36 PDT, Romain Bellessort 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Romain Bellessort
Comment 1 2017-05-18 09:21:35 PDT
Created attachment 310512 [details] Patch
Chris Dumez
Comment 2 2017-05-22 09:41:40 PDT
Comment on attachment 310512 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310512&action=review > Source/WebCore/ChangeLog:17 > + No added test (already covered by existing tests). You cannot say that the behavior change is covered by existing tests but then not rebaseline those tests in the patch. Either: 1. This patch does not change Web-facing behavior 2. The existing tests do not cover the behavior change and more testing should be added
Chris Dumez
Comment 3 2017-05-22 09:48:09 PDT
Comment on attachment 310512 [details] Patch r=me. Code change looks fine but please fix the Changelog to explain that this is not testable (if I understand correctly). If it is testable, please add a test.
Romain Bellessort
Comment 4 2017-05-23 07:36:37 PDT
Created attachment 311009 [details] Patch
Romain Bellessort
Comment 5 2017-05-23 09:04:45 PDT
Thanks for the comment, I updated the ChangeLog to clarify why there was no added test nor updated test expectations (one change does not impact behavior, and the other one is not reachable for the moment).
WebKit Commit Bot
Comment 6 2017-05-23 09:24:42 PDT
Comment on attachment 311009 [details] Patch Clearing flags on attachment: 311009 Committed r217279: <http://trac.webkit.org/changeset/217279>
WebKit Commit Bot
Comment 7 2017-05-23 09:24:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.