Bug 172245

Summary: [MediaStream] do not cache gUM permissions
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: ahmad.saleem792, commit-queue, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch.
youennf: review+
Patch for landing.
none
Patch for landing.
none
Patch for landing.
none
Patch for landing. none

Description Eric Carlson 2017-05-17 14:57:02 PDT 
WebKit should alway ask the user agent for permission to access devices. The user agent can choose to cache responses if it wants to.
Comment 1 Eric Carlson 2017-05-18 06:35:21 PDT 
Created attachment 310505 [details]
Proposed patch.
Comment 2 Radar WebKit Bug Importer 2017-05-18 06:36:00 PDT 
<rdar://problem/32271110>
Comment 3 youenn fablet 2017-05-18 08:03:56 PDT 
Comment on attachment 310505 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=310505&action=review

> Source/WebKit2/UIProcess/UserMediaPermissionRequestProxy.cpp:41
> +    , m_deviceIdentifierHashSalt(deviceIDHashSalt)

WTFMove
Comment 4 Eric Carlson 2017-05-18 10:26:35 PDT 
Created attachment 310515 [details]
Patch for landing.
Comment 5 Eric Carlson 2017-05-18 10:45:56 PDT 
Created attachment 310519 [details]
Patch for landing.
Comment 6 Eric Carlson 2017-05-18 11:57:28 PDT 
Created attachment 310525 [details]
Patch for landing.
Comment 7 Eric Carlson 2017-05-18 13:10:43 PDT 
Created attachment 310541 [details]
Patch for landing.
Comment 8 WebKit Commit Bot 2017-05-18 18:16:51 PDT 
Comment on attachment 310541 [details]
Patch for landing.

Clearing flags on attachment: 310541

Committed r217081: <http://trac.webkit.org/changeset/217081>
Comment 9 Ahmad Saleem 2022-10-05 16:22:43 PDT 
It seems landed but didn't backed out based on each on Webkit GitHub with BugID:

https://github.com/WebKit/WebKit/commit/39b1840ee9c0a82b8944dd902415b78d7838c083

Marking this as "RESOLVED FIXED". Thanks!