Bug 172236

Summary:

Cleanup: Remove unnecessary call to AddToImplIncludes("RuntimeEnabledFeatures.h") in GenerateImplementation()

Product:

WebKit

Reporter:

Daniel Bates <dbates>

Component:

Bindings

Assignee:

Daniel Bates <dbates>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, sam

Priority:

Version:

WebKit Local Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	none

Daniel Bates

Reported 2017-05-17 12:19:06 PDT

It is unnecessary for GenerateImplementation() to explicitly call AddToImplIncludes("RuntimeEnabledFeatures.h") to add the header RuntimeEnabledFeatures.h to the list of headers in the generated implementation as this header is added when GetRuntimeEnableFunctionName() is called. And GenerateImplementation() calls GetRuntimeEnableFunctionName().

Attachments
Patch (2.05 KB, patch) 2017-05-17 12:20 PDT, Daniel Bates	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Daniel Bates

Comment 1 2017-05-17 12:20:04 PDT

Created attachment 310426 [details] Patch

Chris Dumez

Comment 2 2017-05-17 15:10:08 PDT

Comment on attachment 310426 [details] Patch r=me

Daniel Bates

Comment 3 2017-05-18 11:56:37 PDT

Comment on attachment 310426 [details] Patch Clearing flags on attachment: 310426 Committed r217056: <http://trac.webkit.org/changeset/217056>

Daniel Bates

Comment 4 2017-05-18 11:56:39 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.