Bug 172219

Summary:

CSSOM insertRule() index argument is optional with default 0

Product:

WebKit

Reporter:

Sendilkumarn <sendilkumarn.opensource>

Component:

CSS

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, darin, rniwa, sam, simon.fraser, youennf

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://github.com/w3c/csswg-drafts/commit/7949d41a2d86107f8ad4624c055b4b0c9c28ad0d

Attachments:

Description	Flags
Patch	none
Patch	none
Archive of layout-test-results from ews102 for mac-elcapitan	none
Archive of layout-test-results from ews106 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews113 for mac-elcapitan	none
Patch	none

Sendilkumarn

Reported 2017-05-17 07:20:29 PDT

To make index argument optional in insertRule with default 0 Please refer CSSWG-Draft https://github.com/w3c/csswg-drafts/commit/7949d41a2d86107f8ad4624c055b4b0c9c28ad0d Also bugs @ https://www.w3.org/Bugs/Public/show_bug.cgi?id=27384 Added webplatform tests via this issue https://github.com/w3c/web-platform-tests/issues/5524 Thanks

Attachments
Patch (326.41 KB, patch) 2017-05-18 20:05 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (326.33 KB, patch) 2017-05-18 20:40 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews102 for mac-elcapitan (807.81 KB, application/zip) 2017-05-18 21:47 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (916.29 KB, application/zip) 2017-05-18 21:54 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews113 for mac-elcapitan (1.64 MB, application/zip) 2017-05-18 22:00 PDT, Build Bot	no flags	Details
Patch (323.97 KB, patch) 2017-05-18 22:28 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-05-18 20:05:09 PDT

Created attachment 310599 [details] Patch

Chris Dumez

Comment 2 2017-05-18 20:40:27 PDT

Created attachment 310601 [details] Patch

Build Bot

Comment 3 2017-05-18 21:47:38 PDT

Comment on attachment 310601 [details] Patch Attachment 310601 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3773734 New failing tests: imported/w3c/web-platform-tests/cssom/MediaList.xhtml

Build Bot

Comment 4 2017-05-18 21:47:40 PDT

Created attachment 310608 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 5 2017-05-18 21:53:58 PDT

Comment on attachment 310601 [details] Patch Attachment 310601 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3773750 New failing tests: imported/w3c/web-platform-tests/cssom/MediaList.xhtml

Build Bot

Comment 6 2017-05-18 21:54:00 PDT

Created attachment 310610 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 7 2017-05-18 22:00:25 PDT

Comment on attachment 310601 [details] Patch Attachment 310601 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3773739 New failing tests: imported/w3c/web-platform-tests/cssom/MediaList.xhtml

Build Bot

Comment 8 2017-05-18 22:00:26 PDT

Created attachment 310612 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Chris Dumez

Comment 9 2017-05-18 22:18:50 PDT

Comment on attachment 310601 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310601&action=review > LayoutTests/imported/w3c/ChangeLog:28 > + * web-platform-tests/cssom/MediaList.xhtml: Added. Arg. that won't work. 2 files with name name but different extension. They get the same -expected.txt file. @Youenn: Isn't our importer supposed to deal with this somehow?

Chris Dumez

Comment 10 2017-05-18 22:28:36 PDT

Created attachment 310617 [details] Patch

WebKit Commit Bot

Comment 11 2017-05-19 07:11:53 PDT

Comment on attachment 310617 [details] Patch Clearing flags on attachment: 310617 Committed r217125: <http://trac.webkit.org/changeset/217125>

WebKit Commit Bot

Comment 12 2017-05-19 07:11:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.