(In reply to Anne van Kesteren from comment #0)
> Tests:
>
> https://w3c-test.org/url/interfaces.any.html
> https://w3c-test.org/url/interfaces.any.worker.html
Hmm, when I import this test locally, I get:
Harness Error (FAIL), message = Unterminated generic type record, line 20 (tokens: ', USVString> ')
[
{
"type": "other",
"value": ","
},
{
"type": "whitespace",
"value": " "
},
{
"type": "identifier",
"value": "USVString"
},
{
"type": "other",
"value": ">"
},
{
"type": "whitespace",
"value": " "
}
]
PASS Untitled
It is running fine on w3c-test.org though :/ I tried updating our idlharness.js but it did not help.
Created attachment 310437[details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 310444[details]
Archive of layout-test-results from ews115 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 310445[details]
Archive of layout-test-results from ews124 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Created attachment 310448[details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
(In reply to Chris Dumez from comment #1)
> (In reply to Anne van Kesteren from comment #0)
> > Tests:
> >
> > https://w3c-test.org/url/interfaces.any.html
> > https://w3c-test.org/url/interfaces.any.worker.html
>
> Hmm, when I import this test locally, I get:
> Harness Error (FAIL), message = Unterminated generic type record, line 20
> (tokens: ', USVString> ')
> [
> {
> "type": "other",
> "value": ","
> },
> {
> "type": "whitespace",
> "value": " "
> },
> {
> "type": "identifier",
> "value": "USVString"
> },
> {
> "type": "other",
> "value": ">"
> },
> {
> "type": "whitespace",
> "value": " "
> }
> ]
>
> PASS Untitled
>
>
> It is running fine on w3c-test.org though :/ I tried updating our
> idlharness.js but it did not help.
Tentatively re-syncing our WPT tools via Bug 172247 in hope that it addresses this issue.
(In reply to Chris Dumez from comment #1)
> (In reply to Anne van Kesteren from comment #0)
> > Tests:
> >
> > https://w3c-test.org/url/interfaces.any.html
> > https://w3c-test.org/url/interfaces.any.worker.html
>
> Hmm, when I import this test locally, I get:
> Harness Error (FAIL), message = Unterminated generic type record, line 20
> (tokens: ', USVString> ')
> [
> {
> "type": "other",
> "value": ","
> },
> {
> "type": "whitespace",
> "value": " "
> },
> {
> "type": "identifier",
> "value": "USVString"
> },
> {
> "type": "other",
> "value": ">"
> },
> {
> "type": "whitespace",
> "value": " "
> }
> ]
>
> PASS Untitled
>
>
> It is running fine on w3c-test.org though :/ I tried updating our
> idlharness.js but it did not help.
Found the issue. It is webbidl2.js that is outdated. Updating it via Bug 172342.
Created attachment 310620[details]
Archive of layout-test-results from ews117 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 310621[details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 310622[details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 310623[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 310701[details]
Patch
Looks better indeed!
Might want to do some additional clean-up, see below.
Maybe we do not need to add Symbol.Iterator at all in IDLParser.pm and handle it directly in CodeGeneratorJS.pm
View in context: https://bugs.webkit.org/attachment.cgi?id=310701&action=review> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:5439
> + $iterationKind = "Value" if $propertyName eq "entries" and not $interface->iterable->isKeyValue;
We should not need to do anything with Symbol.Iterator here since we are reusing entries or values for that.
We are generating code for nothing probably. Can we remove that case?
Probably also for these function declarations as well.
> Source/WebCore/bindings/scripts/test/JS/JSTestNode.cpp:300
>
Yep, jsTestNodePrototypeFunctionSymbolIterator is probably not needed.
2017-05-17 12:56 PDT, Chris Dumez
2017-05-17 13:48 PDT, Build Bot
2017-05-17 14:13 PDT, Build Bot
2017-05-17 14:25 PDT, Build Bot
2017-05-17 14:56 PDT, Build Bot
2017-05-18 21:38 PDT, Chris Dumez
2017-05-18 21:39 PDT, Chris Dumez
2017-05-18 22:48 PDT, Build Bot
2017-05-18 22:51 PDT, Build Bot
2017-05-18 22:54 PDT, Build Bot
2017-05-18 23:16 PDT, Build Bot
2017-05-19 14:29 PDT, Chris Dumez
2017-05-19 15:26 PDT, Chris Dumez