Bug 172217

Summary:

Regression (198943): <marquee> shouldn't wrap text

Product:

WebKit

Reporter:

Antti Koivisto <koivisto>

Component:

DOM

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, commit-queue, kling

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	none

Description Antti Koivisto 2017-05-17 06:01:13 PDT

<marquee><span>text</span></marquee> should render the text in single line.

Comment 1 Antti Koivisto 2017-05-17 06:15:58 PDT

Created attachment 310385 [details]
patch

Comment 2 Antti Koivisto 2017-05-17 07:21:09 PDT

<rdar://problem/31812669>

Comment 3 Andreas Kling 2017-05-17 07:25:39 PDT

Comment on attachment 310385 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310385&action=review

Wow, I was not expecting to see a marquee patch in 2017. r=me

> Source/WebCore/rendering/RenderMarquee.cpp:200
> -    auto& style = m_layer->renderer().mutableStyle();
> +    auto& style = m_layer->renderer().style();

Nice.

Comment 4 WebKit Commit Bot 2017-05-17 08:12:52 PDT

Comment on attachment 310385 [details]
patch

Clearing flags on attachment: 310385

Committed r216973: <http://trac.webkit.org/changeset/216973>

Comment 5 WebKit Commit Bot 2017-05-17 08:12:53 PDT

All reviewed patches have been landed.  Closing bug.