| Summary: | More WebKit2 header cleanup | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | bdakin, buildbot, ggaren, rniwa, sam, simon.fraser | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Tim Horton
2017-05-17 02:18:38 PDT
Created attachment 310363 [details]
Patch
Attachment 310363 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp:37: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 1 in 29 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 310364 [details]
Patch
This will probably take a few rounds to get building on all the ports I haven't tested. Comment on attachment 310364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310364&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1691 > - if (m_findController.isShowingOverlay()) { > + if (m_findController->isShowingOverlay()) { I wonder if people would prefer to use the (inlinable) findController() method instead so that we can still use dot syntax and don't have to worry about whether it can be null (too bad UniqueRef can't make dot work :( ) Comment on attachment 310364 [details] Patch Attachment 310364 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3763213 New failing tests: http/tests/appcache/404-resource-with-slow-main-resource.php Created attachment 310395 [details]
Archive of layout-test-results from ews101 for mac-elcapitan
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 310364 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310364&action=review >> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1691 >> + if (m_findController->isShowingOverlay()) { > > I wonder if people would prefer to use the (inlinable) findController() method instead so that we can still use dot syntax and don't have to worry about whether it can be null (too bad UniqueRef can't make dot work :( ) Yes. Created attachment 310499 [details]
Patch
|