Bug 172213

Summary: Speedometer: check-in missing React TodoMVC dependency
Product: WebKit Reporter: Addy Osmani <addyo>
Component: Tools / TestsAssignee: Addy Osmani <addyo>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, cdumez, commit-queue, ddkilzer, lforschler, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170513    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Addy Osmani
Reported 2017-05-17 01:57:23 PDT
Missing director.js dependencies must be added back in.
Attachments
Patch (33.94 KB, patch)
2017-05-17 02:00 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (2.58 KB, patch)
2017-05-17 09:46 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Patch (12.15 KB, patch)
2017-05-18 17:46 PDT, Addy Osmani 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Addy Osmani
Comment 1 2017-05-17 02:00:09 PDT
Created attachment 310361 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2017-05-17 04:32:48 PDT
Comment on attachment 310361 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310361&action=review r=me, but consider using director.min.js. > PerformanceTests/Speedometer/resources/todomvc/architecture-examples/react/index.html:17 > + <script src="node_modules/director/director.js"></script> Don't you want to use director.min.js here to match other resources?
Addy Osmani
Comment 3 2017-05-17 09:46:13 PDT
Created attachment 310401 [details] Patch
David Kilzer (:ddkilzer)
Comment 4 2017-05-17 11:28:06 PDT
Comment on attachment 310401 [details] Patch Missing the added files, so the ChangeLog entry is wrong.
David Kilzer (:ddkilzer)
Comment 5 2017-05-17 12:59:44 PDT
(In reply to David Kilzer (:ddkilzer) from comment #4) > Comment on attachment 310401 [details] > Patch > > Missing the added files, so the ChangeLog entry is wrong. And I assume you want to add the files still?
Addy Osmani
Comment 6 2017-05-18 17:29:27 PDT
Yes. Please excuse the missing file - unsure what is dropping `build` directories locally (checked gitignores). I'm going to update this and double check the dependency is definitely in there.
Addy Osmani
Comment 7 2017-05-18 17:46:11 PDT
Created attachment 310582 [details] Patch
Ryosuke Niwa
Comment 8 2017-05-18 19:52:50 PDT
Comment on attachment 310582 [details] Patch r=me.
Ryosuke Niwa
Comment 9 2017-05-18 20:03:56 PDT
Comment on attachment 310582 [details] Patch Clearing flags on attachment: 310582 Committed r217088: <http://trac.webkit.org/changeset/217088>
Ryosuke Niwa
Comment 10 2017-05-18 20:03:58 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.