Bug 17218

Summary:

Metrics pane should be editable

Product:

WebKit

Reporter:

Adam Roben (:aroben) <aroben>

Component:

Web Inspector (Deprecated)

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Enhancement

CC:

kmccullough

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Proposed patch	kmccullough: review+

Adam Roben (:aroben)

Reported 2008-02-08 13:38:10 PST

You should be able to edit an element's metrics directly in the Metrics pane. Firebug does this by letting you double-click on any of the numbers in the Metrics pane.

Attachments
Proposed patch (9.42 KB, patch) 2008-08-20 16:01 PDT, Timothy Hatcher	kmccullough: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Adam Roben (:aroben)

Comment 1 2008-02-08 14:15:57 PST

<rdar://problem/5732818>

Timothy Hatcher

Comment 2 2008-08-20 16:01:12 PDT

Created attachment 22906 [details] Proposed patch

Kevin McCullough

Comment 3 2008-08-21 10:44:24 PDT

Comment on attachment 22906 [details] Proposed patch does editingCancelled need a context?

Timothy Hatcher

Comment 4 2008-08-21 12:55:18 PDT

(In reply to comment #3) > (From update of attachment 22906 [details] [edit]) > does editingCancelled need a context? > The shared editing code calls editingCancelled and passes a context. We don't use it, but it is always passed to us.

Timothy Hatcher

Comment 5 2008-08-21 13:14:55 PDT

Landed fix in r35876.

Note You need to log in before you can comment on or make changes to this bug.