Bug 172174 – Tighten TextIterator::handleTextNode run-renderer mapping logic.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

and bail out of we are out of sync.

[alan]

Created attachment 310271 [details]
Patch

[Antti Koivisto]

Comment on attachment 310271 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310271&action=review

> Source/WebCore/editing/TextIterator.cpp:656
> +        // If the position we are looking for is to the left of the renderer's first run, it means that
> +        // the runs and the renderers are out of sync (e.g. we skipped a renderer in between).
> +        // Better bail out at this point.

Should we have an assert for this?

[alan]

Created attachment 310272 [details]
Patch

[Build Bot]

Comment on attachment 310272 [details]
Patch

Attachment 310272 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3751634

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 310277 [details]
Archive of layout-test-results from ews103 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310272 [details]
Patch

Attachment 310272 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3751742

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 310281 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310272 [details]
Patch

Attachment 310272 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3751778

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 310283 [details]
Archive of layout-test-results from ews105 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[alan]

Created attachment 310346 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 310346 [details]
Patch

Rejecting attachment 310346 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 310346, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ore/rendering/SimpleLineLayoutFunctions.cpp
patching file Source/WebCore/rendering/SimpleLineLayoutFunctions.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/fast/shadow-dom/slot-crash-expected.txt
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/fast/shadow-dom/slot-crash-expected.txt.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3762833

[alan]

Created attachment 310391 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 310391 [details]
Patch

Rejecting attachment 310391 [details] from commit-queue.

New failing tests:
http/tests/media/hls/video-duration-accessibility.html
http/tests/appcache/404-resource-with-slow-main-resource.php
Full output: http://webkit-queues.webkit.org/results/3763806

[WebKit Commit Bot]

Created attachment 310412 [details]
Archive of layout-test-results from webkit-cq-02 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the commit-queue.
Bot: webkit-cq-02  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[alan]

(In reply to WebKit Commit Bot from comment #13)
> Comment on attachment 310391 [details]
> Patch
> 
> Rejecting attachment 310391 [details] from commit-queue.
> 
> New failing tests:
> http/tests/media/hls/video-duration-accessibility.html
> http/tests/appcache/404-resource-with-slow-main-resource.php
> Full output: http://webkit-queues.webkit.org/results/3763806
They look unrelated.

[WebKit Commit Bot]

Comment on attachment 310391 [details]
Patch

Clearing flags on attachment: 310391

Committed r217019: <http://trac.webkit.org/changeset/217019>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.