Bug 172173 – Allow nested timers to propagate user gestures so long as the total nested interval is less than 1s.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

Allow nested timers to propagate user gestures so long as the total nested interval is less than 1s.

[Jer Noble]

Created attachment 310268 [details]
Patch

[Build Bot]

Comment on attachment 310268 [details]
Patch

Attachment 310268 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3751648

New failing tests:
fast/events/popup-blocking-timers4.html
fast/events/popup-blocked-from-untrusted-mouse-click.html

[Build Bot]

Created attachment 310280 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310268 [details]
Patch

Attachment 310268 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3751663

New failing tests:
fast/events/popup-blocking-timers4.html
fast/events/popup-blocked-from-untrusted-mouse-click.html

[Build Bot]

Created attachment 310282 [details]
Archive of layout-test-results from ews107 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310268 [details]
Patch

Attachment 310268 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3751675

New failing tests:
fast/events/popup-blocking-timers4.html
fast/events/popup-blocked-from-untrusted-mouse-click.html

[Build Bot]

Created attachment 310285 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 310268 [details]
Patch

Attachment 310268 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3751623

New failing tests:
media/restricted-audio-playback-with-multiple-settimeouts.html

[Build Bot]

Created attachment 310287 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Jon Lee]

rdar://problem/31991224

[Jon Lee]

*** Bug 171671 has been marked as a duplicate of this bug. ***

[Jer Noble]

Created attachment 310454 [details]
Patch

[Build Bot]

Comment on attachment 310454 [details]
Patch

Attachment 310454 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3765535

New failing tests:
media/restricted-audio-playback-with-multiple-settimeouts.html

[Build Bot]

Created attachment 310470 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Jer Noble]

Created attachment 310487 [details]
Patch

[Eric Carlson]

Comment on attachment 310487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310487&action=review

> LayoutTests/fast/events/popup-blocked-from-untrusted-mouse-click.html:39
> +function waitAWhile(milliseconds) {
> +    return new Promise(resolve => { setTimeout(resolve, milliseconds) });
> +}
> +

Doesn't look like this is used.

[Jer Noble]

(In reply to Eric Carlson from comment #16)
> Comment on attachment 310487 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=310487&action=review
> 
> > LayoutTests/fast/events/popup-blocked-from-untrusted-mouse-click.html:39
> > +function waitAWhile(milliseconds) {
> > +    return new Promise(resolve => { setTimeout(resolve, milliseconds) });
> > +}
> > +
> 
> Doesn't look like this is used.

Good catch; I'll remove it.

[Andy Estes]

Comment on attachment 310487 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310487&action=review

> Source/WebCore/page/DOMTimer.cpp:61
> -    explicit DOMTimerFireState(ScriptExecutionContext& context)
> +    explicit DOMTimerFireState(ScriptExecutionContext& context, int nestingLevel, const Seconds& nestedTimerInterval)

This doesn't need to be marked explicit anymore.

[Jer Noble]

Created attachment 310534 [details]
Patch for landing

[Jer Noble]

Created attachment 310535 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 310535 [details]
Patch for landing

Clearing flags on attachment: 310535

Committed r217063: <http://trac.webkit.org/changeset/217063>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.