Bug 172132

Summary: Remove MediaConstraintsData and MediaConstraintsImpl
Product: WebKit Reporter: youenn fablet <youennf>
Component: MediaAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, eric.carlson, jonlee, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing
none
Patch for landing none

Description youenn fablet 2017-05-15 13:47:33 PDT 
They are not useful as MediaConstraints could really be MediaConstraintsData.
Comment 1 Radar WebKit Bug Importer 2017-05-15 14:22:23 PDT 
<rdar://problem/32206810>
Comment 2 youenn fablet 2017-05-15 14:22:26 PDT 
Created attachment 310164 [details]
Patch
Comment 3 youenn fablet 2017-05-15 14:27:54 PDT 
Created attachment 310166 [details]
Patch
Comment 4 youenn fablet 2017-05-15 16:33:55 PDT 
Created attachment 310178 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-05-15 21:12:38 PDT 
Comment on attachment 310178 [details]
Patch for landing

Rejecting attachment 310178 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 310178, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 file Source/WebKit2/UIProcess/WebPageProxy.cpp
patching file Source/WebKit2/UIProcess/WebPageProxy.h
patching file Source/WebKit2/UIProcess/WebPageProxy.messages.in
patching file Source/WebKit2/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp
patching file Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.cpp
Hunk #2 succeeded at 279 (offset -19 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3748090
Comment 6 youenn fablet 2017-05-15 22:46:34 PDT 
Created attachment 310228 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2017-05-15 23:39:49 PDT 
The commit-queue encountered the following flaky tests while processing attachment 310228 [details]:

The commit-queue is continuing to process your patch.
Comment 8 WebKit Commit Bot 2017-05-15 23:39:57 PDT 
The commit-queue encountered the following flaky tests while processing attachment 310228 [details]:

media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: graouts@apple.com)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Commit Bot 2017-05-16 00:25:58 PDT 
The commit-queue encountered the following flaky tests while processing attachment 310228 [details]:

http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org)
The commit-queue is continuing to process your patch.
Comment 10 WebKit Commit Bot 2017-05-16 00:25:58 PDT 
The commit-queue encountered the following flaky tests while processing attachment 310228 [details]:

The commit-queue is continuing to process your patch.
Comment 11 WebKit Commit Bot 2017-05-16 01:51:54 PDT 
Comment on attachment 310228 [details]
Patch for landing

Clearing flags on attachment: 310228

Committed r216918: <http://trac.webkit.org/changeset/216918>
Comment 12 WebKit Commit Bot 2017-05-16 01:51:56 PDT 
All reviewed patches have been landed.  Closing bug.