Bug 172132 – Remove MediaConstraintsData and MediaConstraintsImpl

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[youenn fablet]

They are not useful as MediaConstraints could really be MediaConstraintsData.

[Radar WebKit Bug Importer]

<rdar://problem/32206810>

[youenn fablet]

Created attachment 310164 [details]
Patch

[youenn fablet]

Created attachment 310166 [details]
Patch

[youenn fablet]

Created attachment 310178 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 310178 [details]
Patch for landing

Rejecting attachment 310178 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 310178, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 file Source/WebKit2/UIProcess/WebPageProxy.cpp
patching file Source/WebKit2/UIProcess/WebPageProxy.h
patching file Source/WebKit2/UIProcess/WebPageProxy.messages.in
patching file Source/WebKit2/WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp
patching file Source/WebKit2/WebProcess/cocoa/UserMediaCaptureManager.cpp
Hunk #2 succeeded at 279 (offset -19 lines).

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/3748090

[youenn fablet]

Created attachment 310228 [details]
Patch for landing

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 310228 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 310228 [details]:

media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-buttons-styles.html bug 168317 (author: [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 310228 [details]:

http/tests/misc/acid3.html bug 165734 (authors: [e-mail], [e-mail], [e-mail], [e-mail], and [e-mail])
The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 310228 [details]:

The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 310228 [details]
Patch for landing

Clearing flags on attachment: 310228

Committed r216918: <http://trac.webkit.org/changeset/216918>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.