Bug 172116

Summary: RenderTheme does not need to be per-page
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, zalan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch
zalan: review+
patch
none
patch none

Antti Koivisto
Reported 2017-05-15 06:42:43 PDT
There are no implementations of RenderTheme::themeForPage that actually care about the page. It can be replaced with a singleton, simplifying a bunch of code.
Attachments
patch (37.35 KB, patch)
2017-05-15 07:08 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (40.42 KB, patch)
2017-05-15 07:18 PDT, Antti Koivisto 		zalan: review+
DetailsFormatted DiffDiff
patch (40.42 KB, patch)
2017-05-15 10:01 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
patch (41.08 KB, patch)
2017-05-15 11:57 PDT, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2017-05-15 06:43:58 PDT
<rdar://problem/30426457>
Antti Koivisto
Comment 2 2017-05-15 07:08:31 PDT
Created attachment 310134 [details] patch
Antti Koivisto
Comment 3 2017-05-15 07:18:30 PDT
Created attachment 310135 [details] patch
Antti Koivisto
Comment 4 2017-05-15 10:01:06 PDT
Created attachment 310144 [details] patch
Antti Koivisto
Comment 5 2017-05-15 11:57:30 PDT
Created attachment 310153 [details] patch
WebKit Commit Bot
Comment 6 2017-05-15 13:17:04 PDT
Comment on attachment 310153 [details] patch Rejecting attachment 310153 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 310153, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing rebase: :040000 040000 841e1e2bc57dce4d72bf15c23ee0f9472213b34e 4fc215fbc6e8a33b7011ebfccb90f898a893d471 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/3745756
Antti Koivisto
Comment 7 2017-05-15 22:35:52 PDT
https://trac.webkit.org/r216902
Note You need to log in before you can comment on or make changes to this bug.