Bug 172091

Summary: Drop PassRefPtr class from WTF
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, darin, ggaren, kling, koivisto, saam, sam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-05-13 22:55:26 PDT
Drop PassRefPtr class from WTF as it is no longer used or needed.
Attachments
Patch (20.02 KB, patch)
2017-05-13 22:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (19.86 KB, patch)
2017-05-13 23:13 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (19.85 KB, patch)
2017-05-13 23:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-13 22:58:57 PDT
Created attachment 310067 [details] Patch
Chris Dumez
Comment 2 2017-05-13 23:13:32 PDT
Created attachment 310068 [details] Patch
Build Bot
Comment 3 2017-05-13 23:15:23 PDT
Attachment 310068 [details] did not pass style-queue: ERROR: Source/WTF/wtf/CrossThreadCopier.cpp:46: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/CrossThreadCopier.cpp:51: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Chris Dumez
Comment 4 2017-05-13 23:19:56 PDT
Created attachment 310070 [details] Patch
Build Bot
Comment 5 2017-05-13 23:22:03 PDT
Attachment 310070 [details] did not pass style-queue: ERROR: Source/WTF/wtf/CrossThreadCopier.cpp:46: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] ERROR: Source/WTF/wtf/CrossThreadCopier.cpp:51: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alex Christensen
Comment 6 2017-05-14 00:03:38 PDT
Comment on attachment 310070 [details] Patch Hooray!
WebKit Commit Bot
Comment 7 2017-05-14 00:31:53 PDT
Comment on attachment 310070 [details] Patch Clearing flags on attachment: 310070 Committed r216839: <http://trac.webkit.org/changeset/216839>
WebKit Commit Bot
Comment 8 2017-05-14 00:31:55 PDT
All reviewed patches have been landed. Closing bug.
Yusuke Suzuki
Comment 9 2017-05-14 06:34:01 PDT
Woohoo!!!
Chris Dumez
Comment 10 2017-05-14 08:32:28 PDT
(In reply to WebKit Commit Bot from comment #7) > Comment on attachment 310070 [details] > Patch > > Clearing flags on attachment: 310070 > > Committed r216839: <http://trac.webkit.org/changeset/216839> \o/ R.I.P. PassRefPtr. \o/
Darin Adler
Comment 11 2017-05-14 08:57:35 PDT
That’s great! Great job Chris.
Saam Barati
Comment 12 2017-05-14 11:02:35 PDT
🎉
Note You need to log in before you can comment on or make changes to this bug.