Bug 172091 - Drop PassRefPtr class from WTF
Summary: Drop PassRefPtr class from WTF
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-13 22:55 PDT by Chris Dumez
Modified: 2017-05-14 11:02 PDT (History)
10 users (show)

See Also:

Attachments
Patch (20.02 KB, patch)
2017-05-13 22:58 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (19.86 KB, patch)
2017-05-13 23:13 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (19.85 KB, patch)
2017-05-13 23:19 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-13 22:55:26 PDT 
Drop PassRefPtr class from WTF as it is no longer used or needed.
Comment 1 Chris Dumez 2017-05-13 22:58:57 PDT 
Created attachment 310067 [details]
Patch
Comment 2 Chris Dumez 2017-05-13 23:13:32 PDT 
Created attachment 310068 [details]
Patch
Comment 3 Build Bot 2017-05-13 23:15:23 PDT 
Attachment 310068 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/CrossThreadCopier.cpp:46:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/CrossThreadCopier.cpp:51:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Chris Dumez 2017-05-13 23:19:56 PDT 
Created attachment 310070 [details]
Patch
Comment 5 Build Bot 2017-05-13 23:22:03 PDT 
Attachment 310070 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/CrossThreadCopier.cpp:46:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
ERROR: Source/WTF/wtf/CrossThreadCopier.cpp:51:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 2 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Alex Christensen 2017-05-14 00:03:38 PDT 
Comment on attachment 310070 [details]
Patch

Hooray!
Comment 7 WebKit Commit Bot 2017-05-14 00:31:53 PDT 
Comment on attachment 310070 [details]
Patch

Clearing flags on attachment: 310070

Committed r216839: <http://trac.webkit.org/changeset/216839>
Comment 8 WebKit Commit Bot 2017-05-14 00:31:55 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Yusuke Suzuki 2017-05-14 06:34:01 PDT 
Woohoo!!!
Comment 10 Chris Dumez 2017-05-14 08:32:28 PDT 
(In reply to WebKit Commit Bot from comment #7)
> Comment on attachment 310070 [details]
> Patch
> 
> Clearing flags on attachment: 310070
> 
> Committed r216839: <http://trac.webkit.org/changeset/216839>

\o/ R.I.P. PassRefPtr. \o/
Comment 11 Darin Adler 2017-05-14 08:57:35 PDT 
That’s great! Great job Chris.
Comment 12 Saam Barati 2017-05-14 11:02:35 PDT 
🎉