Bug 172079

Summary: [cURL] Remove a call to Windows API
Product: WebKit Reporter: Daewoong Jang <daewoong.jang>
Component: WebCore Misc.Assignee: Daewoong Jang <daewoong.jang>
Status: RESOLVED FIXED    
Severity: Normal CC: Basuke.Suzuki, buildbot, commit-queue, galpeter, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
updated patch
none
updated patch none

Description Daewoong Jang 2017-05-13 17:59:42 PDT
Replace MoveFileEx with WebCore::moveFile to support curl on other platforms.
Comment 1 Daewoong Jang 2017-05-13 18:02:03 PDT
Created attachment 310042 [details]
Patch
Comment 2 Daewoong Jang 2017-06-08 22:30:50 PDT
Created attachment 312381 [details]
updated patch
Comment 3 Yusuke Suzuki 2017-06-09 00:34:34 PDT
Comment on attachment 312381 [details]
updated patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312381&action=review

> Source/WebCore/platform/network/curl/CurlDownload.cpp:342
> +    moveFile(m_tempPath, m_destination);

Is there any implementation of moveFile for Windows?
Comment 4 Daewoong Jang 2017-06-09 02:36:43 PDT
Created attachment 312415 [details]
updated patch
Comment 5 Yusuke Suzuki 2017-06-09 03:30:48 PDT
Comment on attachment 312415 [details]
updated patch

r=me
Comment 6 WebKit Commit Bot 2017-06-09 04:00:15 PDT
Comment on attachment 312415 [details]
updated patch

Clearing flags on attachment: 312415

Committed r217977: <http://trac.webkit.org/changeset/217977>
Comment 7 WebKit Commit Bot 2017-06-09 04:00:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Don Olmstead 2017-11-22 13:53:40 PST
*** Bug 173963 has been marked as a duplicate of this bug. ***