Bug 172067

Summary: Drop uses of PassRefPtr in WebKit/win
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit WebsiteAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, darin, joepeck, jond, kling, koivisto, pvollan, rniwa, sam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Chris Dumez 2017-05-12 21:06:47 PDT
Drop uses of PassRefPtr in WebKit/win.
Comment 1 Chris Dumez 2017-05-12 21:31:42 PDT
Created attachment 310009 [details]
Patch
Comment 2 Chris Dumez 2017-05-12 22:33:10 PDT
Created attachment 310013 [details]
Patch
Comment 3 Chris Dumez 2017-05-13 08:39:01 PDT
Created attachment 310018 [details]
Patch
Comment 4 Yusuke Suzuki 2017-05-13 10:21:06 PDT
Comment on attachment 310018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310018&action=review

r=me with a nit.

> Source/WebKit/win/Plugins/PluginDatabase.cpp:528
> +        auto package = PluginPackage::createPackageFromCache(path, lastModified, name, desc, mimeDesc);

This becomes Ref<>, so the following `package && ...`'s meaning is changed. We can drop `package` boolean check, right?
Comment 5 Chris Dumez 2017-05-13 10:31:55 PDT
Comment on attachment 310018 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=310018&action=review

>> Source/WebKit/win/Plugins/PluginDatabase.cpp:528
>> +        auto package = PluginPackage::createPackageFromCache(path, lastModified, name, desc, mimeDesc);
> 
> This becomes Ref<>, so the following `package && ...`'s meaning is changed. We can drop `package` boolean check, right?

Right. This should not even build. It seems this code is disabled at build time on our windows bot.
Comment 6 Chris Dumez 2017-05-13 10:33:35 PDT
Committed r216823: <http://trac.webkit.org/changeset/216823>