Bug 172067

Summary: Drop uses of PassRefPtr in WebKit/win
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit WebsiteAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bfulgham, darin, joepeck, jond, kling, koivisto, pvollan, rniwa, sam, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-05-12 21:06:47 PDT
Drop uses of PassRefPtr in WebKit/win.
Attachments
Patch (45.70 KB, patch)
2017-05-12 21:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (47.92 KB, patch)
2017-05-12 22:33 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (47.86 KB, patch)
2017-05-13 08:39 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-12 21:31:42 PDT
Created attachment 310009 [details] Patch
Chris Dumez
Comment 2 2017-05-12 22:33:10 PDT
Created attachment 310013 [details] Patch
Chris Dumez
Comment 3 2017-05-13 08:39:01 PDT
Created attachment 310018 [details] Patch
Yusuke Suzuki
Comment 4 2017-05-13 10:21:06 PDT
Comment on attachment 310018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310018&action=review r=me with a nit. > Source/WebKit/win/Plugins/PluginDatabase.cpp:528 > + auto package = PluginPackage::createPackageFromCache(path, lastModified, name, desc, mimeDesc); This becomes Ref<>, so the following `package && ...`'s meaning is changed. We can drop `package` boolean check, right?
Chris Dumez
Comment 5 2017-05-13 10:31:55 PDT
Comment on attachment 310018 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=310018&action=review >> Source/WebKit/win/Plugins/PluginDatabase.cpp:528 >> + auto package = PluginPackage::createPackageFromCache(path, lastModified, name, desc, mimeDesc); > > This becomes Ref<>, so the following `package && ...`'s meaning is changed. We can drop `package` boolean check, right? Right. This should not even build. It seems this code is disabled at build time on our windows bot.
Chris Dumez
Comment 6 2017-05-13 10:33:35 PDT
Committed r216823: <http://trac.webkit.org/changeset/216823>
Note You need to log in before you can comment on or make changes to this bug.