Summary: | Drop remaining uses of PassRefPtr in WebKit2/WebProcess | ||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||||
Severity: | Normal | CC: | achristensen, buildbot, commit-queue, darin, ggaren, kling, koivisto, rniwa, sam | ||||||||||||||||
Priority: | P2 | ||||||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||||
OS: | Unspecified | ||||||||||||||||||
Attachments: |
|
Description
Chris Dumez
2017-05-12 15:18:17 PDT
Created attachment 309958 [details]
Patch
Attachment 309958 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4]
Total errors found: 1 in 37 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 309961 [details]
Patch
Attachment 309961 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4]
Total errors found: 1 in 37 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 309963 [details]
Patch
Attachment 309963 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4]
Total errors found: 1 in 37 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 309966 [details]
Patch
Attachment 309966 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4]
Total errors found: 1 in 39 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 309967 [details]
Patch
Created attachment 309968 [details]
Patch
Attachment 309968 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4]
Total errors found: 1 in 43 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 309972 [details]
Patch
Attachment 309972 [details] did not pass style-queue:
ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56: 'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'. [readability/naming/protected] [4]
Total errors found: 1 in 44 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 309972 [details] Patch Clearing flags on attachment: 309972 Committed r216810: <http://trac.webkit.org/changeset/216810> All reviewed patches have been landed. Closing bug. |