Bug 172055

Summary: Drop remaining uses of PassRefPtr in WebKit2/WebProcess
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, darin, ggaren, kling, koivisto, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2017-05-12 15:18:17 PDT
Drop remaining uses of PassRefPtr in WebKit2/WebProcess.
Comment 1 Chris Dumez 2017-05-12 15:47:52 PDT
Created attachment 309958 [details]
Patch
Comment 2 Build Bot 2017-05-12 15:50:51 PDT
Attachment 309958 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56:  'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'.  [readability/naming/protected] [4]
Total errors found: 1 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Chris Dumez 2017-05-12 16:01:21 PDT
Created attachment 309961 [details]
Patch
Comment 4 Build Bot 2017-05-12 16:04:06 PDT
Attachment 309961 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56:  'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'.  [readability/naming/protected] [4]
Total errors found: 1 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Chris Dumez 2017-05-12 16:07:38 PDT
Created attachment 309963 [details]
Patch
Comment 6 Build Bot 2017-05-12 16:09:03 PDT
Attachment 309963 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56:  'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'.  [readability/naming/protected] [4]
Total errors found: 1 in 37 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Chris Dumez 2017-05-12 16:32:40 PDT
Created attachment 309966 [details]
Patch
Comment 8 Build Bot 2017-05-12 16:34:58 PDT
Attachment 309966 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56:  'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'.  [readability/naming/protected] [4]
Total errors found: 1 in 39 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 Chris Dumez 2017-05-12 16:41:43 PDT
Created attachment 309967 [details]
Patch
Comment 10 Chris Dumez 2017-05-12 16:44:11 PDT
Created attachment 309968 [details]
Patch
Comment 11 Build Bot 2017-05-12 16:45:48 PDT
Attachment 309968 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56:  'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'.  [readability/naming/protected] [4]
Total errors found: 1 in 43 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 12 Chris Dumez 2017-05-12 17:10:29 PDT
Created attachment 309972 [details]
Patch
Comment 13 Build Bot 2017-05-12 17:12:00 PDT
Attachment 309972 [details] did not pass style-queue:


ERROR: Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:56:  'renderedImage' is incorrectly named. It should be named 'protector' or 'protectedSnapshotOptions'.  [readability/naming/protected] [4]
Total errors found: 1 in 44 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Chris Dumez 2017-05-12 18:55:18 PDT
Comment on attachment 309972 [details]
Patch

Clearing flags on attachment: 309972

Committed r216810: <http://trac.webkit.org/changeset/216810>
Comment 15 Chris Dumez 2017-05-12 18:55:20 PDT
All reviewed patches have been landed.  Closing bug.