Summary: | [macOS Debug] Layout Test imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html is a flaky timeout. | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Matt Lewis <jlewis3> | ||||||
Component: | New Bugs | Assignee: | Sihui Liu <sihui_liu> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | alecflett, beidson, cdumez, ews-watchlist, jsbell, ryanhaddad, sihui_liu, webkit-bug-importer, youennf | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Matt Lewis
2017-05-12 13:07:29 PDT
Marked as flaky timeout: https://trac.webkit.org/changeset/220932/webkit This is now happening on wk! as well: https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r225411%20(5072)/results.html https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/5072 Added expectations for wk1 in: https://trac.webkit.org/changeset/225432/webkit Created attachment 433962 [details]
Patch
Comment on attachment 433962 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=433962&action=review The code change looks acceptable but landing FAIL baselines for tests is not. > LayoutTests/storage/indexeddb/delete-in-upgradeneeded-close-in-open-success-expected.txt:29 > +FAIL sawVersionChange should be true. Was false. Since those are WebKit tests (not WPT), please fix those tests to reflect the new behavior instead of landing failure expectations. Created attachment 433973 [details]
Patch
Committed r280176 (239871@main): <https://commits.webkit.org/239871@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 433973 [details]. |