Bug 172035

Summary: Memory pressure response should only do sync bmalloc scavenge in sync mode.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, ggaren, kling, msaboff
Priority: P2 Keywords: Performance
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Andreas Kling
Reported 2017-05-12 10:14:38 PDT
Telling bmalloc to synchronously scavenge when we're not in a hurry is silly. Let's not be that silly.
Attachments
Patch (2.64 KB, patch)
2017-05-12 10:18 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2017-05-12 10:18:54 PDT
Created attachment 309909 [details] Patch
Michael Saboff
Comment 2 2017-05-12 10:24:37 PDT
Comment on attachment 309909 [details] Patch r=me
Michael Saboff
Comment 3 2017-05-12 10:32:48 PDT
One thing to note, in my testing on iOS all memory pressure notifications are critical. I have never seen WARN events.
WebKit Commit Bot
Comment 4 2017-05-12 11:21:48 PDT
Comment on attachment 309909 [details] Patch Clearing flags on attachment: 309909 Committed r216770: <http://trac.webkit.org/changeset/216770>
WebKit Commit Bot
Comment 5 2017-05-12 11:21:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.