Bug 172010

Summary: RenderImageResource::hasImage is redundant and RenderImageResourceStyleImage's override is incorrect.
Product: WebKit Reporter: zalan <zalan>
Component: Layout and RenderingAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue, simon.fraser, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

zalan
Reported 2017-05-11 19:31:24 PDT
RenderImageResourceStyleImage::hasImage always returns true which is incorrect see RenderImageResourceStyleImage::image()
Attachments
Patch (10.22 KB, patch)
2017-05-11 19:37 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (10.21 KB, patch)
2017-05-11 20:13 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2017-05-11 19:32:15 PDT
rdar://problem/31086735
zalan
Comment 2 2017-05-11 19:37:48 PDT
Created attachment 309849 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-05-11 19:41:38 PDT
Comment on attachment 309849 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309849&action=review > LayoutTests/fast/images/missing-content-image-crash.html:19 > +missingImage.style.content = "url('http://fakeurl.with-missing.jpg/missing.jpg')"; I think we avoid tests that make random http requests, even if they are to bogus hosts. Not sure if we have canonical test host (example.com?).
zalan
Comment 4 2017-05-11 20:13:05 PDT
Created attachment 309856 [details] Patch
WebKit Commit Bot
Comment 5 2017-05-11 20:56:00 PDT
Comment on attachment 309856 [details] Patch Clearing flags on attachment: 309856 Committed r216728: <http://trac.webkit.org/changeset/216728>
WebKit Commit Bot
Comment 6 2017-05-11 20:56:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.