Bug 172007

Summary:

Drop remaining uses of PassRefPtr under platform/

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Platform

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, ggaren, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none

Chris Dumez

Reported 2017-05-11 18:37:51 PDT

Drop remaining uses of PassRefPtr under platform/.

Attachments
Patch (25.61 KB, patch) 2017-05-11 18:40 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (25.74 KB, patch) 2017-05-11 18:52 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Patch (25.08 KB, patch) 2017-05-11 20:08 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2017-05-11 18:40:54 PDT

Created attachment 309843 [details] Patch

Chris Dumez

Comment 2 2017-05-11 18:52:45 PDT

Created attachment 309846 [details] Patch

Geoffrey Garen

Comment 3 2017-05-11 20:03:53 PDT

Comment on attachment 309846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309846&action=review rs=me > Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:147 > +static bool MockSourceBufferPrivateHasAudio(MockSourceBufferPrivate* sourceBuffer) Maybe MockSourceBufferPrivate&? > Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:157 > +static bool MockSourceBufferPrivateHasVideo(MockSourceBufferPrivate* sourceBuffer) Maybe MockSourceBufferPrivate&?

Ryosuke Niwa

Comment 4 2017-05-11 20:05:10 PDT

Wait, if you want Chris to fix that, you can't cq+ it. commit-queue will just land it as is.

WebKit Commit Bot

Comment 5 2017-05-11 20:05:44 PDT

Comment on attachment 309846 [details] Patch Rejecting attachment 309846 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 309846, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: entMock.h patching file Source/WebCore/platform/mock/RTCNotifiersMock.cpp patching file Source/WebCore/platform/mock/RTCNotifiersMock.h patching file Source/WebCore/platform/mock/TimerEventBasedMock.h patching file Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp patching file Source/WebCore/platform/wpe/RenderThemeWPE.h Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Geoffrey Garen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/3723135

Chris Dumez

Comment 6 2017-05-11 20:07:29 PDT

Comment on attachment 309846 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309846&action=review >> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:147 >> +static bool MockSourceBufferPrivateHasAudio(MockSourceBufferPrivate* sourceBuffer) > > Maybe MockSourceBufferPrivate&? This is passed to std::any_of() with a vector that contains raw pointers. >> Source/WebCore/platform/mock/mediasource/MockMediaSourcePrivate.cpp:157 >> +static bool MockSourceBufferPrivateHasVideo(MockSourceBufferPrivate* sourceBuffer) > > Maybe MockSourceBufferPrivate&? This is passed to std::any_of() with a vector that contains raw pointers.

Chris Dumez

Comment 7 2017-05-11 20:08:56 PDT

Created attachment 309855 [details] Patch

Chris Dumez

Comment 8 2017-05-11 20:15:03 PDT

Comment on attachment 309855 [details] Patch Clearing flags on attachment: 309855 Committed r216724: <http://trac.webkit.org/changeset/216724>

Chris Dumez

Comment 9 2017-05-11 20:15:05 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.