Bug 172000

Summary: Add SPI for overriding WKWebView's clipping behavior for _visibleContentRect
Product: WebKit Reporter: David Quesada <david_quesada>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch v2 none

David Quesada
Reported 2017-05-11 16:40:00 PDT
rdar://problem/32144756
Attachments
Patch (15.52 KB, patch)
2017-05-11 16:44 PDT, David Quesada 		no flags
DetailsFormatted DiffDiff
Patch v2 (15.96 KB, patch)
2017-05-12 16:00 PDT, David Quesada 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Quesada
Comment 1 2017-05-11 16:44:29 PDT
Created attachment 309821 [details] Patch
Simon Fraser (smfr)
Comment 2 2017-05-12 15:34:15 PDT
Comment on attachment 309821 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=309821&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2178 > +- (UIView *)_enclosingView I think this name is too generic; it could easily conflict with a UIKit method, and it has a very particular usage, so we should name it accordingly. How about _enclosingViewForExposedRectComputation?
David Quesada
Comment 3 2017-05-12 15:40:28 PDT
(In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 309821 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=309821&action=review > > > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:2178 > > +- (UIView *)_enclosingView > > I think this name is too generic; it could easily conflict with a UIKit > method, and it has a very particular usage, so we should name it accordingly. > > How about _enclosingViewForExposedRectComputation? Sure.
David Quesada
Comment 4 2017-05-12 16:00:27 PDT
Created attachment 309960 [details] Patch v2
WebKit Commit Bot
Comment 5 2017-05-12 16:29:32 PDT
Comment on attachment 309960 [details] Patch v2 Clearing flags on attachment: 309960 Committed r216802: <http://trac.webkit.org/changeset/216802>
WebKit Commit Bot
Comment 6 2017-05-12 16:29:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.