Bug 171996

Summary: Annotate Ref::ptr() with RETURNS_NONNULL
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Web Template FrameworkAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cmarcelo, commit-queue, dbates, kling
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2017-05-11 15:31:12 PDT
Annotate Ref::ptr() with RETURNS_NONNULL as it can never return null.
Attachments
Patch (1.25 KB, patch)
2017-05-11 15:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-05-11 15:31:50 PDT
Created attachment 309798 [details] Patch
Andreas Kling
Comment 2 2017-05-11 15:37:30 PDT
Comment on attachment 309798 [details] Patch k
Chris Dumez
Comment 3 2017-05-11 15:39:23 PDT
(In reply to Andreas Kling from comment #2) > Comment on attachment 309798 [details] > Patch > > k FYI, this did not impact binary size.
WebKit Commit Bot
Comment 4 2017-05-11 16:33:02 PDT
The commit-queue encountered the following flaky tests while processing attachment 309798 [details]: workers/bomb.html bug 171985 (author: fpizlo@apple.com) http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org) The commit-queue is continuing to process your patch.
WebKit Commit Bot
Comment 5 2017-05-11 16:33:33 PDT
Comment on attachment 309798 [details] Patch Clearing flags on attachment: 309798 Committed r216700: <http://trac.webkit.org/changeset/216700>
WebKit Commit Bot
Comment 6 2017-05-11 16:33:34 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.