Bug 171996 - Annotate Ref::ptr() with RETURNS_NONNULL
Summary: Annotate Ref::ptr() with RETURNS_NONNULL
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
Depends on:
Reported: 2017-05-11 15:31 PDT by Chris Dumez
Modified: 2017-05-11 16:33 PDT (History)
6 users (show)

See Also:

Patch (1.25 KB, patch)
2017-05-11 15:31 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-05-11 15:31:12 PDT
Annotate Ref::ptr() with RETURNS_NONNULL as it can never return null.
Comment 1 Chris Dumez 2017-05-11 15:31:50 PDT
Created attachment 309798 [details]
Comment 2 Andreas Kling 2017-05-11 15:37:30 PDT
Comment on attachment 309798 [details]

Comment 3 Chris Dumez 2017-05-11 15:39:23 PDT
(In reply to Andreas Kling from comment #2)
> Comment on attachment 309798 [details]
> Patch
> k

FYI, this did not impact binary size.
Comment 4 WebKit Commit Bot 2017-05-11 16:33:02 PDT
The commit-queue encountered the following flaky tests while processing attachment 309798 [details]:

workers/bomb.html bug 171985 (author: fpizlo@apple.com)
http/tests/misc/acid3.html bug 165734 (authors: abecsi@webkit.org, arv@chromium.org, cdumez@apple.com, rniwa@webkit.org, and tonyg@chromium.org)
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-05-11 16:33:33 PDT
Comment on attachment 309798 [details]

Clearing flags on attachment: 309798

Committed r216700: <http://trac.webkit.org/changeset/216700>
Comment 6 WebKit Commit Bot 2017-05-11 16:33:34 PDT
All reviewed patches have been landed.  Closing bug.