Bug 171913

Summary:

Add an experimental feature flag for constant properties

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

New Bugs

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, bdakin, buildbot, dino, hyatt, rniwa, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews101 for mac-elcapitan	none
Archive of layout-test-results from ews116 for mac-elcapitan	none
Patch	none

Description Tim Horton 2017-05-10 00:36:01 PDT

Add an experimental feature flag for constant properties

Comment 1 Tim Horton 2017-05-10 00:36:24 PDT

Created attachment 309583 [details]
Patch

Comment 2 Build Bot 2017-05-10 01:46:53 PDT

Comment on attachment 309583 [details]
Patch

Attachment 309583 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3710506

New failing tests:
fast/css/variables/constants/safe-area-inset-zero.html
fast/css/variables/constants/safe-area-inset-cannot-override.html

Comment 3 Build Bot 2017-05-10 01:46:55 PDT

Created attachment 309584 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 4 Build Bot 2017-05-10 02:08:33 PDT

Comment on attachment 309583 [details]
Patch

Attachment 309583 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3710549

New failing tests:
fast/css/variables/constants/safe-area-inset-zero.html
fast/css/variables/constants/safe-area-inset-cannot-override.html

Comment 5 Build Bot 2017-05-10 02:08:35 PDT

Created attachment 309585 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

Comment 6 Ryosuke Niwa 2017-05-10 02:12:17 PDT

Comment on attachment 309583 [details]
Patch

Please do fix the tests before landing.

Comment 7 Tim Horton 2017-05-10 10:15:50 PDT

Well, it's good that the tests failed :) I will fix them.

Comment 8 Tim Horton 2017-05-10 11:23:22 PDT

Created attachment 309620 [details]
Patch

Comment 9 Tim Horton 2017-05-10 13:27:40 PDT

https://trac.webkit.org/changeset/216611/webkit

Comment 10 Alexey Proskuryakov 2017-05-11 20:18:43 PDT

I'm never sure about how these settings work - are these reset between tests?

Comment 11 Ryosuke Niwa 2017-05-11 20:19:15 PDT

(In reply to Alexey Proskuryakov from comment #10)
> I'm never sure about how these settings work - are these reset between tests?

They're.