Bug 171876

Summary: REGRESSION(r213564): Flash audio playback failures
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit2Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, ap, bfulgham, ggaren, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ap: review+

Brent Fulgham
Reported 2017-05-09 12:24:36 PDT
Some Flash audio playback stopped working after r213564. This was caused by a syntax error in the regular expression that should have resolved to IOAudioEngineDescription. While reviewing these changes, I also discovered that "iokit-property" requires spaces to be escaped to get a proper match. This patch corrects both problems.
Attachments
Patch (1.86 KB, patch)
2017-05-12 12:03 PDT, Brent Fulgham 		ap: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-05-09 12:24:59 PDT
<rdar://problem/32082745>
Brent Fulgham
Comment 2 2017-05-12 12:03:44 PDT
Created attachment 309923 [details] Patch
Brent Fulgham
Comment 3 2017-05-12 12:30:12 PDT
(In reply to Brent Fulgham from comment #2) > Created attachment 309923 [details] > Patch Note: After discussions with the Sandbox experts, I learned that it is NOT necessary to escape spaces in the sandbox rules.
Alexey Proskuryakov
Comment 4 2017-05-12 13:28:56 PDT
Comment on attachment 309923 [details] Patch Unmaintainable.
Brent Fulgham
Comment 5 2017-05-12 13:43:04 PDT
Committed r216790: <http://trac.webkit.org/changeset/216790>
Brent Fulgham
Comment 6 2017-05-15 17:50:54 PDT
Note: Follow-up fixed landed in: Committed r216893: <http://trac.webkit.org/changeset/216893>
Note You need to log in before you can comment on or make changes to this bug.